From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbso8-0006na-KV for qemu-devel@nongnu.org; Tue, 15 Sep 2015 12:10:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbso3-0006AN-Ls for qemu-devel@nongnu.org; Tue, 15 Sep 2015 12:10:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbso3-00068k-Gp for qemu-devel@nongnu.org; Tue, 15 Sep 2015 12:10:07 -0400 References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com> <1439563931-12352-9-git-send-email-guangrong.xiao@linux.intel.com> <20150825160353.GD8344@stefanha-thinkpad.redhat.com> <55DD979A.70804@linux.intel.com> <20150828115851.GM4917@stefanha-thinkpad.redhat.com> <55E3F2EF.8070501@linux.intel.com> <20150901091400.GB5051@stefanha-thinkpad.redhat.com> From: Paolo Bonzini Message-ID: <55F842D9.2010104@redhat.com> Date: Tue, 15 Sep 2015 18:10:01 +0200 MIME-Version: 1.0 In-Reply-To: <20150901091400.GB5051@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, Stefan Hajnoczi , mtosatti@redhat.com, qemu-devel@nongnu.org, imammedo@redhat.com, rth@twiddle.net On 01/09/2015 11:14, Stefan Hajnoczi wrote: >> > >> > When I was digging into live migration code, i noticed that the same MR name may >> > cause the name "idstr", please refer to qemu_ram_set_idstr(). >> > >> > Since nvdimm devices do not have parent-bus, it will trigger the abort() in that >> > function. > I see. The other devices that use a constant name are on a bus so the > abort doesn't trigger. However, the MR name must be the same across the two machines. Indices are not friendly to hotplug. Even though hotplug isn't supported now, we should prepare and try not to change migration format when we support hotplug in the future. Is there any other fixed value that we can use, for example the base address of the NVDIMM? Paolo