From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com,
dgilbert@redhat.com, vsementsov@parallels.com,
stefanha@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com,
den@openvz.org, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block
Date: Tue, 15 Sep 2015 10:29:23 -0600 [thread overview]
Message-ID: <55F84763.2020905@redhat.com> (raw)
In-Reply-To: <1438939964-12584-12-git-send-email-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote:
> From: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
>
> Reviewed-by: John Snow <jsnow@redhat.com>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block.c | 1 +
> include/qemu/hbitmap.h | 8 ++++++++
> qapi/block-core.json | 4 +++-
> util/hbitmap.c | 8 ++++++++
> 4 files changed, 20 insertions(+), 1 deletion(-)
> +++ b/qapi/block-core.json
> @@ -359,11 +359,13 @@
> #
> # @status: current status of the dirty bitmap (since 2.4)
> #
> +# @md5: md5 checksum of the last bitmap level (since 2.4)
since 2.5, now. Would it help to be explicit that this is a hexadecimal
encoding of the checksum (and not the actual binary value)?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-09-15 16:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 9:32 [Qemu-devel] [PATCH v6 00/12] Dirty bitmaps migration Vladimir Sementsov-Ogievskiy
2015-08-07 9:32 ` [Qemu-devel] [PATCH 01/12] hbitmap: serialization Vladimir Sementsov-Ogievskiy
2015-08-20 14:53 ` Stefan Hajnoczi
2015-08-07 9:32 ` [Qemu-devel] [PATCH 02/12] block: BdrvDirtyBitmap serialization interface Vladimir Sementsov-Ogievskiy
2015-08-07 9:32 ` [Qemu-devel] [PATCH 03/12] block: tiny refactoring: minimize hbitmap_(set/reset) usage Vladimir Sementsov-Ogievskiy
2015-08-07 9:32 ` [Qemu-devel] [PATCH 04/12] block: add meta bitmaps Vladimir Sementsov-Ogievskiy
2015-08-07 9:32 ` [Qemu-devel] [PATCH 05/12] block: add bdrv_next_dirty_bitmap() Vladimir Sementsov-Ogievskiy
2015-08-07 9:32 ` [Qemu-devel] [PATCH 06/12] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2015-09-15 16:27 ` Eric Blake
2015-08-07 9:32 ` [Qemu-devel] [PATCH 07/12] migration/qemu-file: add qemu_put_counted_string() Vladimir Sementsov-Ogievskiy
2015-09-11 0:02 ` John Snow
2015-08-07 9:32 ` [Qemu-devel] [PATCH 08/12] migration: add migration/block-dirty-bitmap.c Vladimir Sementsov-Ogievskiy
2015-09-11 0:10 ` John Snow
2015-08-07 9:32 ` [Qemu-devel] [PATCH 09/12] iotests: maintain several vms in test Vladimir Sementsov-Ogievskiy
2015-08-07 9:32 ` [Qemu-devel] [PATCH 10/12] iotests: add add_incoming_migration to VM class Vladimir Sementsov-Ogievskiy
2015-08-07 9:32 ` [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block Vladimir Sementsov-Ogievskiy
2015-09-15 16:29 ` Eric Blake [this message]
2015-09-15 19:44 ` John Snow
2015-09-16 5:22 ` Markus Armbruster
2015-08-07 9:32 ` [Qemu-devel] [PATCH 12/12] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2015-08-07 10:10 ` [Qemu-devel] [PATCH v6 00/12] Dirty bitmaps migration Vladimir Sementsov-Ogievskiy
2015-09-11 0:11 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F84763.2020905@redhat.com \
--to=eblake@redhat.com \
--cc=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@parallels.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).