From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbt6n-0005fA-Lf for qemu-devel@nongnu.org; Tue, 15 Sep 2015 12:29:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbt6j-0007KZ-LL for qemu-devel@nongnu.org; Tue, 15 Sep 2015 12:29:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbt6j-0007KV-Gv for qemu-devel@nongnu.org; Tue, 15 Sep 2015 12:29:25 -0400 References: <1438939964-12584-1-git-send-email-vsementsov@virtuozzo.com> <1438939964-12584-12-git-send-email-vsementsov@virtuozzo.com> From: Eric Blake Message-ID: <55F84763.2020905@redhat.com> Date: Tue, 15 Sep 2015 10:29:23 -0600 MIME-Version: 1.0 In-Reply-To: <1438939964-12584-12-git-send-email-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OnTi6Ei8Bcthe2gXsQHvjV7BuFcrnNCUP" Subject: Re: [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com, dgilbert@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com, den@openvz.org, jsnow@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OnTi6Ei8Bcthe2gXsQHvjV7BuFcrnNCUP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy >=20 > Reviewed-by: John Snow > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 1 + > include/qemu/hbitmap.h | 8 ++++++++ > qapi/block-core.json | 4 +++- > util/hbitmap.c | 8 ++++++++ > 4 files changed, 20 insertions(+), 1 deletion(-) > +++ b/qapi/block-core.json > @@ -359,11 +359,13 @@ > # > # @status: current status of the dirty bitmap (since 2.4) > # > +# @md5: md5 checksum of the last bitmap level (since 2.4) since 2.5, now. Would it help to be explicit that this is a hexadecimal encoding of the checksum (and not the actual binary value)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OnTi6Ei8Bcthe2gXsQHvjV7BuFcrnNCUP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+EdjAAoJEKeha0olJ0NqUmkH/jixHi6bKIjH/H5S3i02/UX0 bNxl0deE35NzcMIr3EdlRSykB9NpUG86it0s9aprBTOveMuWTh0wI9l0bb+blUOE 2XU2KlGgwgPoyro1FzlDalajwPSUtCTdRkolyRnSSh7zkle59VPw65gAtarwdQnO lYkFa4ShmvMY7S5NAFKar5i8+geQw31NkDZM0PA13SRO2GwuIPMjs5mn4Wix29pi 1HeV/7mWiczXioUgB5X+k81OzC3uI6pMTyMHKrtD3yprSR/Whwm4jNXvV8u1XaXF LAHgJJsyifCIPL5F2ZcbGVDYs9k7bPz2jwS82b2yFGNYNXtrWcI6kCFcYW/5diM= =g/dY -----END PGP SIGNATURE----- --OnTi6Ei8Bcthe2gXsQHvjV7BuFcrnNCUP--