From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbwA0-0005cE-99 for qemu-devel@nongnu.org; Tue, 15 Sep 2015 15:45:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbw9x-0001tz-0w for qemu-devel@nongnu.org; Tue, 15 Sep 2015 15:45:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbw9w-0001tZ-SS for qemu-devel@nongnu.org; Tue, 15 Sep 2015 15:44:56 -0400 References: <1438939964-12584-1-git-send-email-vsementsov@virtuozzo.com> <1438939964-12584-12-git-send-email-vsementsov@virtuozzo.com> <55F84763.2020905@redhat.com> From: John Snow Message-ID: <55F87536.4080503@redhat.com> Date: Tue, 15 Sep 2015 15:44:54 -0400 MIME-Version: 1.0 In-Reply-To: <55F84763.2020905@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com, dgilbert@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com, den@openvz.org On 09/15/2015 12:29 PM, Eric Blake wrote: > On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Reviewed-by: John Snow >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> block.c | 1 + >> include/qemu/hbitmap.h | 8 ++++++++ >> qapi/block-core.json | 4 +++- >> util/hbitmap.c | 8 ++++++++ >> 4 files changed, 20 insertions(+), 1 deletion(-) > >> +++ b/qapi/block-core.json >> @@ -359,11 +359,13 @@ >> # >> # @status: current status of the dirty bitmap (since 2.4) >> # >> +# @md5: md5 checksum of the last bitmap level (since 2.4) > > since 2.5, now. Would it help to be explicit that this is a hexadecimal > encoding of the checksum (and not the actual binary value)? > I had reasoned that it was implied so as to maintain a valid QMP protocol stream.