From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1Zc1Fx-0000Fd-OD
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 21:11:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1Zc1Fs-0000Pm-QD
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 21:11:29 -0400
Received: from mga09.intel.com ([134.134.136.24]:60840)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1Zc1Fs-0000LC-KH
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 21:11:24 -0400
References: <alpine.DEB.2.02.1509081818590.2672@kaball.uk.xensource.com>
	<CAFEAcA80p5jaGYstmXYH204OExVUm2Mn=qfxC3FeibzPNDi7Tw@mail.gmail.com>
	<alpine.DEB.2.02.1509091248460.2672@kaball.uk.xensource.com>
	<alpine.DEB.2.02.1509091706120.2672@kaball.uk.xensource.com>
	<55F0DB30.6070607@intel.com>
	<CAFEAcA9RM0Q0ZrhgZxYqRdYb+GTsd7QyZtNJGKqxOYse8vShfA@mail.gmail.com>
	<55F14E20.6070805@intel.com>
	<alpine.DEB.2.02.1509101041540.2672@kaball.uk.xensource.com>
	<alpine.DEB.2.02.1509101122570.2672@kaball.uk.xensource.com>
	<55F69A18.20709@redhat.com>
	<alpine.DEB.2.02.1509151053410.2672@kaball.uk.xensource.com>
	<55F7FA43.40600@redhat.com>
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Message-ID: <55F8C1B8.6060509@intel.com>
Date: Wed, 16 Sep 2015 09:11:20 +0800
MIME-Version: 1.0
In-Reply-To: <55F7FA43.40600@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "xen-devel@lists.xensource.com Devel" <xen-devel@lists.xensource.com>, QEMU Developers <qemu-devel@nongnu.org>, mst@redhat.com

On 9/15/2015 7:00 PM, Paolo Bonzini wrote:
>
>
> On 15/09/2015 11:55, Stefano Stabellini wrote:
>> On Mon, 14 Sep 2015, Paolo Bonzini wrote:
>>> > On 10/09/2015 12:29, Stefano Stabellini wrote:
>>>> > > +    if (lseek(config_fd, pos, SEEK_SET) != pos) {
>>>> > > +        return -errno;
>>>> > > +    }
>>>> > >      do {
>>>> > > -        rc = pread(config_fd, (uint8_t *)&val, len, pos);
>>>> > > +        rc = read(config_fd, (uint8_t *)&val, len);
>>>> > >      } while (rc < 0 && (errno == EINTR || errno == EAGAIN));
>>> >
>>> > This leaks config_fd.
>> I don't follow, it leaks config_fd where?
>
> Where lseek returns -errno (and IIRC in other places in the same function).

Do you mean we need this change?

diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 1fb71c8..7d44228 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -775,15 +775,18 @@ static int host_pci_config_read(int pos, int len, 
uint32_t val)
      }

      if (lseek(config_fd, pos, SEEK_SET) != pos) {
+        close(config_fd);
          return -errno;
      }
      do {
          rc = read(config_fd, (uint8_t *)&val, len);
      } while (rc < 0 && (errno == EINTR || errno == EAGAIN));
      if (rc != len) {
+        close(config_fd);
          return -errno;
      }

+    close(config_fd);
      return 0;
  }


Thanks
Tiejun