From: Paolo Bonzini <pbonzini@redhat.com>
To: Houcheng Lin <houcheng@gmail.com>,
qemu-devel@nongnu.org, famz@redhat.com
Cc: linhaocheng@itri.org.tw, Peter Maydell <peter.maydell@linaro.org>,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [RFC PATCH] os-android: Add support to android platform, built by ndk-r10
Date: Wed, 16 Sep 2015 10:09:09 +0200 [thread overview]
Message-ID: <55F923A5.3000605@redhat.com> (raw)
In-Reply-To: <CAL8JtxC43ng+XKqP1HTtf1QE0DMTFiw-mQD=O8KT-VGKVrxfMA@mail.gmail.com>
On 15/09/2015 19:34, Houcheng Lin wrote:
> Hi Paolo,
>
> (Please ignore the previous mail that did not include "qemu-devel")
>
> Thanks for your review and suggestions. I'll fix this patch
> accordingly and please see my replies below.
>
> best regards,
> Houcheng Lin
>
> 2015-09-15 17:41 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>> This is okay and can be done unconditionally (introduce a new
>> qemu_getdtablesize function that is defined in util/oslib-posix.c).
>
> Will fix it.
>>
>>
>>> - sigtimewait(): call __rt_sigtimewait() instead.
>>> - lockf(): not see this feature in android, directly return -1.
>>> - shm_open(): not see this feature in android, directly return -1.
>>
>> This is not okay. Please fix your libc instead.
>
> I'll modify the bionic C library to support these functions and feedback
> to google's AOSP project. But the android kernel does not support shmem,
It doesn't support tmpfs? /dev/shm is just a tmpfs.
Paolo
next prev parent reply other threads:[~2015-09-16 8:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442283070-3224-1-git-send-email-houcheng@gmail.com>
[not found] ` <55F7E7B8.9020502@redhat.com>
2015-09-15 17:34 ` [Qemu-devel] [RFC PATCH] os-android: Add support to android platform, built by ndk-r10 Houcheng Lin
2015-09-16 8:09 ` Paolo Bonzini [this message]
2015-09-16 9:28 ` Houcheng Lin
2015-09-16 9:38 ` Paolo Bonzini
2015-09-16 9:54 ` Houcheng Lin
2015-09-16 10:28 ` Paolo Bonzini
2015-09-15 5:11 Houcheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F923A5.3000605@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=houcheng@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linhaocheng@itri.org.tw \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).