From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48783)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Zc7mI-0003FJ-Of
	for qemu-devel@nongnu.org; Wed, 16 Sep 2015 04:09:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Zc7mF-0004EI-Ja
	for qemu-devel@nongnu.org; Wed, 16 Sep 2015 04:09:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36790)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Zc7mF-0004EC-EC
	for qemu-devel@nongnu.org; Wed, 16 Sep 2015 04:09:15 -0400
References: <1442283070-3224-1-git-send-email-houcheng@gmail.com>
	<55F7E7B8.9020502@redhat.com>
	<CAL8JtxC43ng+XKqP1HTtf1QE0DMTFiw-mQD=O8KT-VGKVrxfMA@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55F923A5.3000605@redhat.com>
Date: Wed, 16 Sep 2015 10:09:09 +0200
MIME-Version: 1.0
In-Reply-To: <CAL8JtxC43ng+XKqP1HTtf1QE0DMTFiw-mQD=O8KT-VGKVrxfMA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH] os-android: Add support to android
 platform, built by ndk-r10
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Houcheng Lin <houcheng@gmail.com>, qemu-devel@nongnu.org, famz@redhat.com
Cc: linhaocheng@itri.org.tw, Peter Maydell <peter.maydell@linaro.org>, kvm@vger.kernel.org



On 15/09/2015 19:34, Houcheng Lin wrote:
> Hi Paolo,
> 
> (Please ignore the previous mail that did not include "qemu-devel")
> 
> Thanks for your review and suggestions. I'll fix this patch
> accordingly and please see my replies below.
> 
> best regards,
> Houcheng Lin
> 
> 2015-09-15 17:41 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
> 
>> This is okay and can be done unconditionally (introduce a new
>> qemu_getdtablesize function that is defined in util/oslib-posix.c).
> 
> Will fix it.
>>
>>
>>>     - sigtimewait(): call __rt_sigtimewait() instead.
>>>     - lockf(): not see this feature in android, directly return -1.
>>>     - shm_open(): not see this feature in android, directly return -1.
>>
>> This is not okay.  Please fix your libc instead.
> 
> I'll modify the bionic C library to support these functions and feedback
> to google's AOSP project. But the android kernel does not support shmem,

It doesn't support tmpfs?  /dev/shm is just a tmpfs.

Paolo