From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zc9KV-0006ka-PT for qemu-devel@nongnu.org; Wed, 16 Sep 2015 05:48:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zc9KS-0004Us-KR for qemu-devel@nongnu.org; Wed, 16 Sep 2015 05:48:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zc9KS-0004Uo-Ef for qemu-devel@nongnu.org; Wed, 16 Sep 2015 05:48:40 -0400 References: <1441783481-17698-1-git-send-email-yanghy@cn.fujitsu.com> <55F65685.7080504@cn.fujitsu.com> <55F659A4.7090705@redhat.com> <55F65CD6.1020009@cn.fujitsu.com> From: Jason Wang Message-ID: <55F93AF1.8030005@redhat.com> Date: Wed, 16 Sep 2015 17:48:33 +0800 MIME-Version: 1.0 In-Reply-To: <55F65CD6.1020009@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v10 00/10] Add a netfilter object and netbuffer filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, thuth@redhat.com, zhang.zhanghailiang@huawei.com, stefanha@redhat.com, armbru@redhat.com On 09/14/2015 01:36 PM, Yang Hongyang wrote: > > > On 09/14/2015 01:22 PM, Jason Wang wrote: >> >> >> On 09/14/2015 01:09 PM, Yang Hongyang wrote: >>> Hi Stefan,Jason, >>> >>> I've convert this series to base on QOM, and introducing NetQueue apis >>> instead of using Netqueue internals as Stefan suggested. Could you >>> please take a >>> look at it? >> >> Will go through this in next few days. > > Thanks a lot. Looks good to me overall. Just have small nitpicks, see individual replies for details. If you want to send V11, may be worth to consider them. (But not a requirement). Thanks