From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcByb-00074H-EF for qemu-devel@nongnu.org; Wed, 16 Sep 2015 08:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcByZ-00008h-8E for qemu-devel@nongnu.org; Wed, 16 Sep 2015 08:38:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcByZ-00008b-3d for qemu-devel@nongnu.org; Wed, 16 Sep 2015 08:38:15 -0400 References: <1441806613-13775-1-git-send-email-pbonzini@redhat.com> <1441806613-13775-20-git-send-email-pbonzini@redhat.com> <1442407057.26770.11.camel@redhat.com> From: Paolo Bonzini Message-ID: <55F962B2.3040200@redhat.com> Date: Wed, 16 Sep 2015 14:38:10 +0200 MIME-Version: 1.0 In-Reply-To: <1442407057.26770.11.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 19/43] rcu: init rcu_registry_lock after fork List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "Emilio G. Cota" , qemu-devel@nongnu.org On 16/09/2015 14:37, Gerd Hoffmann wrote: > On Mi, 2015-09-09 at 15:49 +0200, Paolo Bonzini wrote: >> > From: "Emilio G. Cota" >> > >> > We were unlocking this lock after fork, which is wrong since >> > only the thread that holds a mutex is allowed to unlock it. > This breaks libvirt capability probing. I see qemu running: > > /home/kraxel/projects/qemu/build-default/x86_64-softmmu/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M none -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait -pidfile /var/lib/libvirt/qemu/capabilities.pidfile -daemonize > > and libvirt is stuck until I kill qemu. Yes, Laszlo reported this already. The patch was included by mistake and I've already sent a revert. Paolo