From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcDIS-0001mN-L8 for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:02:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcDIO-0000Ym-Du for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:02:52 -0400 References: <1442411543-28513-1-git-send-email-berrange@redhat.com> <1442411543-28513-2-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <55F97678.1050201@redhat.com> Date: Wed, 16 Sep 2015 08:02:32 -0600 MIME-Version: 1.0 In-Reply-To: <1442411543-28513-2-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uWcT2Am8j5vb1mQSmfgLlNa6i0D1XNG5p" Subject: Re: [Qemu-devel] [PATCH v1 1/2] nbd: convert to use the QAPI SocketAddress object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uWcT2Am8j5vb1mQSmfgLlNa6i0D1XNG5p Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/16/2015 07:52 AM, Daniel P. Berrange wrote: > The nbd block driver currently uses a QemuOpts object > when setting up sockets. Switch it over to use the > QAPI SocketAddress object instead. >=20 > Signed-off-by: Daniel P. Berrange > --- > block/nbd.c | 69 +++++++++++++++++++++++++++++++++--------------------= -------- > 1 file changed, 37 insertions(+), 32 deletions(-) Reviewed-by: Eric Blake Wen - this patch will help in your efforts to expose NBD via blockdev-add QMP. > - if (!qemu_opt_get(s->socket_opts, "port")) { > - qemu_opt_set_number(s->socket_opts, "port", NBD_DEFAULT_PORT, > - &error_abort); > - } > + s->client.is_unix =3D saddr->kind =3D=3D SOCKET_ADDRESS_KIND_UNIX;= > =20 Minor conflict with my pending patch to rename the C representation of qapi unions to spell things with 'type': https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02598.html but as that needs to be rebased once Markus' introspection lands, you don't have to wait for it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uWcT2Am8j5vb1mQSmfgLlNa6i0D1XNG5p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+XZ4AAoJEKeha0olJ0NqQDEIAJdJI3W7sTTzNNiBQZ85X7xo pMR1hUIC58IZLrelKAphyGov15o/V9iUsqsWp9dpyt67yYpCVAzO1peG3JguU/b7 0eI4snifqenkPw6Idg5y9F629XYS/y2OBtz8s9n8a2tliuEmIo2XTUSkKrrPYNbh aN7SkXN07LtN575i1U7hRquqDoFvExehu68bys+CjNtjcBAUqMWQI0hwibIr0rik mtGr/SUN9baf/ifEtzZjNkAe4Wj4itk7kC0j0ET/mhJaBYxUqnuRF7GsVJeHjj5B u8JjjIysgrKBV3K8LTGyvO9+4II8TeDY8dwi1DjG9Jj2PuB+slCcwy6kEuAIgB4= =af80 -----END PGP SIGNATURE----- --uWcT2Am8j5vb1mQSmfgLlNa6i0D1XNG5p--