From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcDLy-0004BI-Kk for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:06:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcDLu-0002Tv-Kn for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:06:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcDLu-0002Tp-CO for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:06:26 -0400 References: <1442301035-7550-1-git-send-email-yuanhan.liu@linux.intel.com> <55F954DA.3090006@gmail.com> <20150916122349.GI2339@yliu-dev.sh.intel.com> From: Marcel Apfelbaum Message-ID: <55F9775E.4070207@redhat.com> Date: Wed, 16 Sep 2015 17:06:22 +0300 MIME-Version: 1.0 In-Reply-To: <20150916122349.GI2339@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/7 v9] vhost-user multiple queue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuanhan Liu Cc: jasowang@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, changchun.ouyang@intel.com On 09/16/2015 03:23 PM, Yuanhan Liu wrote: > On Wed, Sep 16, 2015 at 02:39:06PM +0300, Marcel Apfelbaum wrote: >> On 09/15/2015 10:10 AM, Yuanhan Liu wrote: >>> Hi, >>> >>> Here is the updated patch set for enabling vhost-user multiple queue. >> >> Hi, >> >> I think this series will not work with the current DPDK vhost-user MQ patches, > > Yes. The new patch set since v7 has made interface changes. Hence it > will not work the v4 DPDK vhost-user MQ patches. > >> can you please post an RFC on the dpdk list? > > I guess you could see that soon, before the end of this week. Appreciated! Marcel > > --yliu > > >> If you don't have anything reedy yet, a pointer to a git would also be appreciated. >> >> Thanks, >> Marcel >> >>> >>> This patch set introduces 2 more vhost user messages: VHOST_USER_GET_QUEUE_NUM, >>> for querying how many queues the backend supports, and VHOST_USER_SET_VRING_ENABLE, >>> for enabling/disabling a specific virt queue. >>> >>> Both of the two new messages are treated as vhost protocol extension, >>> and that's why Michaels's patch "vhost-user: add protocol feature >>> negotiation" is also included here. >>> >>> Patch 1-5 are all prepare works for actually enabling multiple queue. >>> >>> Patch 6 is the major patch for enabling multiple queue, which also tries >>> to address two major concerns from Michael: no feedback from backend if >>> it can't support # of requested queues, and all messages are sent N time. >>> It also fixes a hidden bug. >>> >>> Patch 7 introduces the VHOST_USER_SET_VRING_ENABLE message, to enable >>> or disable a specific vring. >>> >>> Note that I haven't done any formal test yet, it just passes build >>> test and basic functional test, such as it does exit when backend >>> doesn't support # of requested queues. Here I sent it out just for >>> more comments, and for avoiding spending too much effort on the wrong >>> track. >>> >>> >>> v9: - Per suggested by Jason Wang, patch 5 introduces a new vhost >>> backend method: vhost_backend_get_vq_index(). >>> >>> - Use qemu_find_net_clients_except() at net/vhost-user.c for >>> gathering all related ncs so that we could register chr dev >>> event handler once. Which is also suggested by Jason Wang. >>> >>> >>> Thanks. >>> >>> --yliu >>> >>> --- >>> Changchun Ouyang (2): >>> vhost-user: add multiple queue support >>> vhost-user: add a new message to disable/enable a specific virt queue. >>> >>> Michael S. Tsirkin (1): >>> vhost-user: add protocol feature negotiation >>> >>> Yuanhan Liu (4): >>> vhost-user: use VHOST_USER_XXX macro for switch statement >>> vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE >>> vhost-user: add VHOST_USER_GET_QUEUE_NUM message >>> vhost: introduce vhost_backend_get_vq_index method >>> >>> docs/specs/vhost-user.txt | 75 +++++++++++++++++++- >>> hw/net/vhost_net.c | 39 ++++++++-- >>> hw/net/virtio-net.c | 8 +++ >>> hw/virtio/vhost-backend.c | 10 ++- >>> hw/virtio/vhost-user.c | 143 +++++++++++++++++++++++++++++++------ >>> hw/virtio/vhost.c | 20 +++--- >>> include/hw/virtio/vhost-backend.h | 4 ++ >>> include/hw/virtio/vhost.h | 2 + >>> include/net/vhost_net.h | 3 + >>> linux-headers/linux/vhost.h | 2 +- >>> net/vhost-user.c | 146 +++++++++++++++++++++++++++----------- >>> qapi-schema.json | 6 +- >>> qemu-options.hx | 5 +- >>> tests/vhost-user-test.c | 2 +- >>> 14 files changed, 380 insertions(+), 85 deletions(-) >>>