From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcDVF-0003Ox-70 for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:16:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcDVC-0007ee-Tz for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:16:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcDVC-0007eW-MN for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:16:02 -0400 References: <1442301035-7550-1-git-send-email-yuanhan.liu@linux.intel.com> <1442301035-7550-8-git-send-email-yuanhan.liu@linux.intel.com> <55F832EF.9030500@redhat.com> <20150916020656.GD2339@yliu-dev.sh.intel.com> From: Eric Blake Message-ID: <55F9799F.3090802@redhat.com> Date: Wed, 16 Sep 2015 08:15:59 -0600 MIME-Version: 1.0 In-Reply-To: <20150916020656.GD2339@yliu-dev.sh.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2VlvM9bLDRHLqHDsMe2ErNln8ad5jXGT2" Subject: Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuanhan Liu Cc: jasowang@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, changchun.ouyang@intel.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2VlvM9bLDRHLqHDsMe2ErNln8ad5jXGT2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/15/2015 08:06 PM, Yuanhan Liu wrote: >> Up to here is mostly fine for the commit message. Meanwhile... >> >>> v9: per suggested by Jason Wang, we could invoke qemu_chr_add_handler= s() >>> once only, and invoke qemu_find_net_clients_except() at the handl= er >>> to gather all related ncs, for initiating all queues. Which addre= sses >>> a hidden bug in older verion in a more QEMU-like way. >>> >>> v8: set net->dev.vq_index correctly inside vhost_net_init() based on = the >>> value from net->nc->queue_index. >> >> ...this chunk here is useful only on the mailing list, and not in git,= >> and therefore, should appear... >=20 > Sorry that I may disagree here. >=20 > First of all, it does no harm at all to include few old version > descriptions. Instead, it may give some hints to the reader how > the patch evolves. Meanwhile, you will find they are quite common > in some well known open source projects, such as linux kernel: There's nothing wrong with including patch changelog in your mail; in fact it is encouraged by: http://wiki.qemu.org/Contribute/SubmitAPatch However, we DO request that you put it after ---, because we do NOT want it in qemu.git log. I don't care if the kernel has a slightly different policy, and is more tolerant of changelogs leaked into the git log. > You can find them at qemu project (though not that common), too: >=20 > [yliu@yliu-dev ~/qemu]$ git log | grep '\<[vV][1-9][0-9]*:' | wc -l= > 390 They're not common for a reason - we've documented that we don't like them in git. And that's because we expect the --- separator between the git message and the changelog. >=20 > So, if it's a qemu community specific culture, I could do what > you suggested. Yes, since it is documented at http://wiki.qemu.org/Contribute/SubmitAPatch, it is qemu culture. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2VlvM9bLDRHLqHDsMe2ErNln8ad5jXGT2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+XmfAAoJEKeha0olJ0NqFusIAKLPE39cxvk95leqrRObHSz+ A6qtgmBWXytUsrrWky6trCgOuM3Zc+82FosCmJBVxmuKQ+GQ6KqpuFqkh4zunt2g jsErz9/31b82z5+tGDlXekmg0lLRxIN57ULYVLD7HIGitX4svHxSQj4T74AL/m90 YkjxEo7x2DqtretUyZU+L9h6MydjgZ6CFJtQ/05vKIZuw730kJGjrtz0wf7bbuJI begQXa+TYEZ4mkiyOP/1XXWAKa/a30R+I3p/daGphiI3KCS4cN9qIoEwajw18qvT 1XZ21eDujJPcMQ2VQbBQ2Bay2dF0rvph3aJXSvugeuVlTgDc9jj6S4l8TZibvf8= =E85t -----END PGP SIGNATURE----- --2VlvM9bLDRHLqHDsMe2ErNln8ad5jXGT2--