From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZcDar-0005Au-Hk
	for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:21:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZcDam-0002BW-5C
	for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:21:53 -0400
References: <1442411543-28513-1-git-send-email-berrange@redhat.com>
	<1442411543-28513-2-git-send-email-berrange@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55F97AF3.4060700@redhat.com>
Date: Wed, 16 Sep 2015 16:21:39 +0200
MIME-Version: 1.0
In-Reply-To: <1442411543-28513-2-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 1/2] nbd: convert to use the QAPI
	SocketAddress object
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org



On 16/09/2015 15:52, Daniel P. Berrange wrote:
> +    saddr = nbd_config(s, options, &export, &local_err);

You can use errp directly here.  Otherwise looks fine.

Paolo

> +    if (!saddr) {
>          error_propagate(errp, local_err);
>          return -EINVAL;
>      }