From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcDcj-0006A8-1W for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:23:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcDci-0002iF-De for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:23:49 -0400 References: <1442411543-28513-1-git-send-email-berrange@redhat.com> <1442411543-28513-3-git-send-email-berrange@redhat.com> <55F977E3.2060807@redhat.com> <20150916141335.GF21184@redhat.com> From: Paolo Bonzini Message-ID: <55F97B6B.7040504@redhat.com> Date: Wed, 16 Sep 2015 16:23:39 +0200 MIME-Version: 1.0 In-Reply-To: <20150916141335.GF21184@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 2/2] qemu-nbd: convert to use the QAPI SocketAddress object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Eric Blake Cc: Kevin Wolf , qemu-devel@nongnu.org, qemu-block@nongnu.org On 16/09/2015 16:13, Daniel P. Berrange wrote: > > The qapi type is gross for requiring port as a string. But we have plans > > to clean that up, not a showstopper for this patch. > > On the contrary - QAPI is correct in requiring this, as it lets you > provide a service name (as defined in /etc/services) instead of a > numeric port, and getaddrinfo() will look that up and convert to > numeric format. Was going to say the same. :) I'll fix up patch 1 and apply both. Paolo