From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcEMh-0007UL-Qk for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:11:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcEMc-000810-26 for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:11:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcEMb-00080q-Sx for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:11:13 -0400 References: <1442401589-24189-1-git-send-email-armbru@redhat.com> <1442401589-24189-4-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55F98690.1030609@redhat.com> Date: Wed, 16 Sep 2015 09:11:12 -0600 MIME-Version: 1.0 In-Reply-To: <1442401589-24189-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NfSQmCkRewtIaHVTDEe41T9bQboPLJ0Mi" Subject: Re: [Qemu-devel] [PATCH v8 03/26] qapi: QAPISchema code generation helper methods List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NfSQmCkRewtIaHVTDEe41T9bQboPLJ0Mi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/16/2015 05:06 AM, Markus Armbruster wrote: > New methods c_name(), c_type(), c_null(), json_type(), > alternate_qtype(). >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 94 +++++++++++++++++++++++++++++++++++++++++++++++++= +++----- > 1 file changed, 87 insertions(+), 7 deletions(-) >=20 > @@ -790,6 +830,16 @@ class QAPISchemaEnumType(QAPISchemaType): > def check(self, schema): > assert len(set(self.values)) =3D=3D len(self.values) > =20 > + def c_type(self, is_param=3DFalse): > + return c_name(self.name) > + > + def c_null(self): > + return c_enum_const(self.name, (self.values + ['MAX'])[0], > + self.prefix) Yep, that becomes important in later patches. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NfSQmCkRewtIaHVTDEe41T9bQboPLJ0Mi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+YaQAAoJEKeha0olJ0NqbPgIAK701fsjNAfbvRZcJ3shUXfi xfG8FXnCkWBgOO9DD+Fuc31KmqbxXcujWCCIeVPOg+y6RN010+pDVTp4sRSA0nbm GPeDM0rggu43wjkopF/C8rGzVvO/DuLwms9qoN8dtHiOaIu6pDbWSJGcXvKanjYC W+btJTPFifLUsJKVnlSXN7duhA2Nw5o1eoLiglvqJXYswUyOGkTotg947ezIlrVs smZYQtTpOOloyNns3npZTfOvpvkQk5sUOK3GNBl/zzv1HVJLHIxW43T/otjEOksl daemvSV1ZMFIcLDz8SoMEkmcf947zYcno/ieLtxVq06fK+Q/NQrfxzBR/uJYFUA= =33we -----END PGP SIGNATURE----- --NfSQmCkRewtIaHVTDEe41T9bQboPLJ0Mi--