From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcEm8-0007oc-Qf for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:37:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcEm4-0002b7-AU for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:37:36 -0400 References: <1441140641-17631-1-git-send-email-jsnow@redhat.com> From: John Snow Message-ID: <55F98CB5.3070806@redhat.com> Date: Wed, 16 Sep 2015 11:37:25 -0400 MIME-Version: 1.0 In-Reply-To: <1441140641-17631-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] ahci: clean up signature generation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org On 09/01/2015 04:50 PM, John Snow wrote: > Ultimately, clean up the signature generation and as a result, tidy up > the port_reset and init_d2h functions. > > ________________________________________________________________________________ > > For convenience, this branch is available at: > https://github.com/jnsnow/qemu.git branch ahci-sigfix > https://github.com/jnsnow/qemu/tree/ahci-sigfix > > This version is tagged ahci-sigfix-v1: > https://github.com/jnsnow/qemu/releases/tag/ahci-sigfix-v1 > > John Snow (4): > ahci: remove dead reset code > ahci: fix signature generation > ahci: remove cmd_fis argument from write_fis_d2h > ahci: clean up initial d2h semantics > > hw/ide/ahci.c | 53 ++++++++++++++++++++++++++++++----------------------- > 1 file changed, 30 insertions(+), 23 deletions(-) > Ping -- Stefan, you had some comments on the predecessor to this patch for 2.4, does this look saner to you?