From: Eric Blake <eblake@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] utils: rename strtosz to use qemu prefix
Date: Wed, 16 Sep 2015 10:13:14 -0600 [thread overview]
Message-ID: <55F9951A.1040804@redhat.com> (raw)
In-Reply-To: <1442419377-9309-1-git-send-email-marcandre.lureau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On 09/16/2015 10:02 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Not only it makes sense, but it gets rid of checkpatch warning:
> WARNING: consider using qemu_strtosz in preference to strtosz
Indeed, POSIX reserves the entire str*() namespace for future extension,
so avoiding the collision is worthwhile.
>
> Also remove get rid of tabs to please checkpatch.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-09-16 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 16:02 [Qemu-devel] [PATCH 1/2] utils: rename strtosz to use qemu prefix marcandre.lureau
2015-09-16 16:02 ` [Qemu-devel] [PATCH 2/2] tests: add some qemu_strtosz() tests marcandre.lureau
2015-09-16 16:19 ` Eric Blake
2015-09-16 16:13 ` Eric Blake [this message]
2015-09-16 16:17 ` [Qemu-devel] [PATCH 1/2] utils: rename strtosz to use qemu prefix Marc-André Lureau
2015-09-16 16:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F9951A.1040804@redhat.com \
--to=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).