From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcGCn-0002RK-8y for qemu-devel@nongnu.org; Wed, 16 Sep 2015 13:09:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcGCk-0003Uy-4M for qemu-devel@nongnu.org; Wed, 16 Sep 2015 13:09:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcGCj-0003Ut-W7 for qemu-devel@nongnu.org; Wed, 16 Sep 2015 13:09:10 -0400 References: <1442401589-24189-1-git-send-email-armbru@redhat.com> <1442401589-24189-7-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55F9A230.30107@redhat.com> Date: Wed, 16 Sep 2015 11:09:04 -0600 MIME-Version: 1.0 In-Reply-To: <1442401589-24189-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hv1wmVK400NdSj5PGP5ejPRBSpSe6lIhK" Subject: Re: [Qemu-devel] [PATCH v8 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hv1wmVK400NdSj5PGP5ejPRBSpSe6lIhK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Fixes flat unions to get the base's base members. Test case is from > commit 2fc0043, in qapi-schema-test.json: >=20 >=20 > Flat union visitors remain broken. They'll be fixed next. >=20 > Two ugly special cases for simple unions now stand out like sore > thumbs: >=20 > 1. The type tag is named 'type' everywhere, except in generated C, > where it's 'kind'. >=20 > 2. QAPISchema lowers simple unions to semantically equivalent flat > unions. However, the C generated for a simple unions differs from > the C generated for its equivalent flat union, and we therefore > need special code to preserve that pointless difference for now. >=20 > Mark both TODO. >=20 > Signed-off-by: Markus Armbruster > --- > + > + def visit_enum_type(self, name, info, values, prefix): > + self._fwdecl +=3D generate_enum(name, values, prefix) > + self._fwdefn +=3D generate_enum_lookup(name, values, prefix) straightforward. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hv1wmVK400NdSj5PGP5ejPRBSpSe6lIhK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+aIwAAoJEKeha0olJ0NqTcoH/A98WWEhlgOf0L7PWqkpsp25 gP67vTtXEvuZRPthzs6Je+6WZtpRI88sRBhgOlFLxaHsKD2BwlOjRycZpT4xSg/b KfJM0s/p6y94ii2Snj940QButaLKFYgnCIRrhPxOGLQtXdrlymkptEs608oYpuh/ v20G4PpelZOovQxoUu9XTDIaYAY7Zaz+KiO800U/KufTSB7JcodfIS142lHgucyk HZfMq0Kgthqgmf0vkhfsiEA6hjI2mTDLnzWiJtQ0kMilFQdApQjTg28nXwUc56tA LvwWRaSjpOs3ZvjjKIEn1KIZv+NDusrYqGay6CzrsSiBdEx2U+TWHFC0NACLvZY= =tpg+ -----END PGP SIGNATURE----- --hv1wmVK400NdSj5PGP5ejPRBSpSe6lIhK--