From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcGE8-0004Wi-R0 for qemu-devel@nongnu.org; Wed, 16 Sep 2015 13:10:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcGE5-0004LD-Fr for qemu-devel@nongnu.org; Wed, 16 Sep 2015 13:10:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcGE5-0004L7-AH for qemu-devel@nongnu.org; Wed, 16 Sep 2015 13:10:33 -0400 References: <1442401589-24189-1-git-send-email-armbru@redhat.com> <1442401589-24189-8-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55F9A287.9000707@redhat.com> Date: Wed, 16 Sep 2015 11:10:31 -0600 MIME-Version: 1.0 In-Reply-To: <1442401589-24189-8-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CLnFCh7qatIEXxIJoOGAPChRsu9Bfmb6p" Subject: Re: [Qemu-devel] [PATCH v8 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CLnFCh7qatIEXxIJoOGAPChRsu9Bfmb6p Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Fixes flat unions to visit the base's base members (the previous > commit merely added them to the struct). Same test case. >=20 > Test cases updated for the bug fix. >=20 > Fixes alternates to generate a visitor for their implicit enumeration > type. None of them are currently used, obviously. Example: > block-core.json's BlockdevRef now generates > visit_type_BlockdevRefKind(). >=20 > The previous commit's two ugly special cases exist here, too. Mark > both TODO. >=20 > Signed-off-by: Markus Armbruster > --- > + > + def visit_enum_type(self, name, info, values, prefix): > + self.decl +=3D gen_visit_decl(name, scalar=3DTrue) > + self.defn +=3D generate_visit_enum(name) Not even used; just part of the overriding contract. I don't know if python has any convention for marking known-unused parameters, so this looks okay to me :) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CLnFCh7qatIEXxIJoOGAPChRsu9Bfmb6p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+aKHAAoJEKeha0olJ0NqDpgIAJ6snsbNuD965cC+ZUqWT60a x7J3FT2SrtFAMgG3AvBTEgu0jhgj08pNqgm6bnrenygFoDYkTF+ryjc0t6FwXcEk oiIthOeKPitWkjyO2SigMC/Rc4Fna1Vxvz/fsMrYDO1mjdUupQDkveqxyXWLGAbr fVpUYprVpKA7XH++VG1U6boSNaFPYYHdjnT2VRDO1cIRr/1CxchcR21QXUJGGgmT iD536YJdueJDQgw7Xm105mwYkWIKkegTapdyHrXSM552KNNSYBbfwd8HgKqGKm4a gCSbIMCWqvFUzwyxUyGi+s4WE+NaRtzA5i7SpLWbyTgTyQGgFLgKIb2wHy3q8xI= =kFU3 -----END PGP SIGNATURE----- --CLnFCh7qatIEXxIJoOGAPChRsu9Bfmb6p--