From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcGNa-0001MI-Lq for qemu-devel@nongnu.org; Wed, 16 Sep 2015 13:20:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcGNV-0008TC-No for qemu-devel@nongnu.org; Wed, 16 Sep 2015 13:20:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcGNV-0008Sp-IY for qemu-devel@nongnu.org; Wed, 16 Sep 2015 13:20:17 -0400 References: <1442401589-24189-1-git-send-email-armbru@redhat.com> <1442401589-24189-14-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55F9A4CF.1020808@redhat.com> Date: Wed, 16 Sep 2015 11:20:15 -0600 MIME-Version: 1.0 In-Reply-To: <1442401589-24189-14-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Lxe3REnpieNJCJqAfewh5L8DPKfGjOSAK" Subject: Re: [Qemu-devel] [PATCH v8 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Lxe3REnpieNJCJqAfewh5L8DPKfGjOSAK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Generate just 'FOO' instead of 'struct FOO' when possible. >=20 > Drop helper functions that are now unused. >=20 > Make pep8 and pylint reasonably happy. >=20 > Rename generate_FOO() functions to gen_FOO() for consistency. >=20 > Use more consistent and sensible variable names. >=20 > Consistently use c_ for mapping keys when their value is a C > identifier or type. >=20 > Simplify gen_enum() and gen_visit_union() >=20 > Consistently use single quotes for C text string literals. >=20 > Signed-off-by: Markus Armbruster > --- Diff from v7 limited to handling of enum prefix. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Lxe3REnpieNJCJqAfewh5L8DPKfGjOSAK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+aTPAAoJEKeha0olJ0NqcxkH/2Cc8FM96lseYgFJOzorrEQk fgVoTIvPk5EziOUVBXY03SsjEeIEXzLUmLE7Qg6vCqBuyRqbSGmNorcalDpLz/9C PMGMncuVXMfC1xc7cLwbZZI81sYnHhp0avyKpJxWIGsX7OvgCPZA0V2A+qw5pVf6 FSuNwdDuCDXu2RUaFRa2wj2EpKlAQ51hQEjit4dOLpArlJGKH67tRogSBhNEBE1o zMyWl/xGzYi+hD02LyrxaVD4STqy39rtoVGQmERk0GE+14Go2YZZCoZ57CjeWws2 8+Ljog6Yo9mn/f3IfYreAAIiy2gMFcUzw10/z3H1fqykVYzhVDL9H1or1c6UbwI= =ugb+ -----END PGP SIGNATURE----- --Lxe3REnpieNJCJqAfewh5L8DPKfGjOSAK--