From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43501)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZcYcg-0005CP-LY
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 08:49:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZcYcc-0004sM-HJ
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 08:49:10 -0400
Received: from mga01.intel.com ([192.55.52.88]:30721)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZcYcc-0004sA-CA
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 08:49:06 -0400
References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1439563931-12352-9-git-send-email-guangrong.xiao@linux.intel.com>
	<20150825160353.GD8344@stefanha-thinkpad.redhat.com>
	<55DD979A.70804@linux.intel.com>
	<20150828115851.GM4917@stefanha-thinkpad.redhat.com>
	<55E3F2EF.8070501@linux.intel.com>
	<20150901091400.GB5051@stefanha-thinkpad.redhat.com>
	<55F842D9.2010104@redhat.com> <55FA7C30.10208@linux.intel.com>
	<20150917110452.1ffaed44@nial.brq.redhat.com>
	<55FA8468.4000108@linux.intel.com> <55FA892E.6080207@redhat.com>
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Message-ID: <55FAB55A.8040701@linux.intel.com>
Date: Thu, 17 Sep 2015 20:43:06 +0800
MIME-Version: 1.0
In-Reply-To: <55FA892E.6080207@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory
 mapping and config data area
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, Stefan Hajnoczi <stefanha@gmail.com>, mtosatti@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, rth@twiddle.net



On 09/17/2015 05:34 PM, Paolo Bonzini wrote:
>
>
> On 17/09/2015 11:14, Xiao Guangrong wrote:
>>
>>
>> /* get the memory region from backend memory. */
>> mr = host_memory_backend_get_memory(dimm->hostmem, errp);
>>
>> /* nvdimm_nr will map to guest address space. */
>> memory_region_init_alias(&nvdimm->nvdimm_mr, OBJECT(dev),
>>                           object_get_canonical_path(OBJECT(dev)), mr, 0,
>>                           size - nvdimm->label_size);
>
> You can just use "memory" here for the name here.  The name only needs
> to be unique for RAM memory regions, and dimm->hostmem will take care of it.
>

Okay. I will try it, thank you, Paolo.