From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcaHK-0003gF-3a for qemu-devel@nongnu.org; Thu, 17 Sep 2015 10:35:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcaHF-0000YN-3l for qemu-devel@nongnu.org; Thu, 17 Sep 2015 10:35:14 -0400 References: <1441857991-7309-1-git-send-email-eblake@redhat.com> <1441857991-7309-28-git-send-email-eblake@redhat.com> <55FA84C5.8060206@cn.fujitsu.com> From: Eric Blake Message-ID: <55FACF90.408@redhat.com> Date: Thu, 17 Sep 2015 08:34:56 -0600 MIME-Version: 1.0 In-Reply-To: <55FA84C5.8060206@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ks4LeNAVobkDB5aC59c3xjIbOIHdCIGHm" Subject: Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , qemu-devel@nongnu.org Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Vincenzo Maffione , Luiz Capitulino , Max Filippov , Gerd Hoffmann , Dmitry Fleytman , "Edgar E. Iglesias" , Rob Herring , armbru@redhat.com, Scott Feldman , =?UTF-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= , marcandre.lureau@redhat.com, Jiri Pirko , Alistair Francis , Jan Kiszka , Stefan Hajnoczi , Giuseppe Lettieri , Luigi Rizzo , David Gibson , Alexander Graf , Peter Crosthwaite , Michael Walle , "open list:sPAPR pseries" , Peter Chubb This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ks4LeNAVobkDB5aC59c3xjIbOIHdCIGHm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/17/2015 03:15 AM, Wen Congyang wrote: > On 09/10/2015 12:06 PM, Eric Blake wrote: >> From: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n >> >> Except qapi-schema.json, this patch was generated by: >> >> find . -name .git -prune -o -type f \! -name '*~' -print0 | \ >> xargs -0 sed -i \ >> -e 's/NetClientOptionsKind/NetClientDriver/g' \ >> -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER_/g' \ >> -e 's/netdev->opts/netdev/g' >> >> Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n >> Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.D= irtY.iCE.hu@gmail.com> >> >> Additional changes: >> Rebase the patch on top of an earlier change from netdev->kind to >> netdev->type, so that tweak no longer needed here. >> >> Rework so that NetdevLegacy doesn't pollute QMP command but is instead= >> copied piecewise into the new Netdev, which means that NetClientOption= s >> must still remain in qapi. Since legacy previously always rejected >> 'hubport', we can now make that explicit by having the two unions be >> slightly different; but that means we must manually map between the >> two structures. >=20 > I apply Markus's v8 patch and this series, make check will fail: > TEST: tests/virtio-net-test... (pid=3D23648) > /x86_64/virtio/net/pci/basic: = qemu-system-x86_64: -netdev socket,fd=3D6,id=3Dhs0: Invalid parameter 'fd= ' Oh dear. I guess I was focused on 'make check-qapi-schema', and forgot to test the rest of the suite. The bug is most likely in my patches, and will be fixed by the time I post v5, now that you've pointed it out to me. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ks4LeNAVobkDB5aC59c3xjIbOIHdCIGHm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+s+QAAoJEKeha0olJ0Nq9WkH/jBNI83phEbdlhbOU95O9hLC BtOnvQZ4JTt947MiPAUpZMebZB+kpzI/Wqez9kkMtuJ9PzxzABXGOsi6F9hOuIKR OQ8DFJNa/S2da6nbfOYOxif3daMDE8WS73rszKbcoFmAvyIPteIT+eIX3YZvxd9Q L7TuojFuxwLTHE9aBmhhTHF0nJ6TQrSGbVxMzxc6JxViRCpyNZRvTDbQ8L+Wc+UC +0CQDgS0Q/GPQRFWo+ZqBkqKBU1zPzjXVWrED9eP9IR33MuQJA3Kq6gyLZsvDPjN aye8eg9mJ/ZyE4WBJ6hGIu43ZTjUI/sNBnXxA/GfELJZcVn9ExmI3vw8Vk7XXck= =qraa -----END PGP SIGNATURE----- --Ks4LeNAVobkDB5aC59c3xjIbOIHdCIGHm--