From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcbkz-0000ik-Ht for qemu-devel@nongnu.org; Thu, 17 Sep 2015 12:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcbkw-0005M5-6A for qemu-devel@nongnu.org; Thu, 17 Sep 2015 12:09:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcbkv-0005Lf-O8 for qemu-devel@nongnu.org; Thu, 17 Sep 2015 12:09:54 -0400 References: <1442405768-23019-1-git-send-email-yanghy@cn.fujitsu.com> <1442405768-23019-3-git-send-email-yanghy@cn.fujitsu.com> <55F9DA8A.1090306@redhat.com> <55FA1602.2090309@cn.fujitsu.com> From: Eric Blake Message-ID: <55FAE5CA.20808@redhat.com> Date: Thu, 17 Sep 2015 10:09:46 -0600 MIME-Version: 1.0 In-Reply-To: <55FA1602.2090309@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r2XQ7XJge8mFC1ic0J0haP3gNkghjqvOj" Subject: Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, armbru@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --r2XQ7XJge8mFC1ic0J0haP3gNkghjqvOj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/16/2015 07:23 PM, Yang Hongyang wrote: >>> +{ 'enum': 'NetFilterChain', >>> + 'data': [ 'all', 'in', 'out' ] } >> >> I don't see any other QMP usage of this enum anywhere in the series. A= re >> you planning on supporting QMP? If so, let's get that design discussi= on >> started. If not, why not? >=20 > This series is based on QOM, so the QMP command for object_add > will use this enum, for example: > 1 { "execute": "qmp_capabilities" } > 2 { "execute": "object-add", > 3 "arguments": { "qom-type": "filter-buffer", > 4 "id": "f0", > 5 "props": { "netdev": "bn0", > 6 "chain": "in", > 7 "interval": 2000 } } } >=20 > for hmp: > object_add filter-buffer,id=3Df0,netdev=3Dbn0,chain=3Din,interval=3D100= 0 >=20 > command options: > -object filter-buffer,id=3Df0,netdev=3Dbn0,chain=3Din,interval=3D1000 Do these examples appear in the documentation anywhere? If not, it is worth considering (maybe under 'object-add' in qmp-commands.hx, for example). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --r2XQ7XJge8mFC1ic0J0haP3gNkghjqvOj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+uXKAAoJEKeha0olJ0NqZtQH/2SqvwkP3rml6XDb8gWKNr6Q 3H23w6ntk96rShgv4r48kjP7XJQe0rhDmjern1vXSfDLTBHWh/hoe8L7cZaM+H+j 21aFpPcyIjNGpO5nFNUB+Ml3B7AQGx41pB8skF7VzXHSCoAI02s/P52xqL7Urgjx n6JBPjnfVqstgglGRFk63tYazArkl7Eacv+piTBRE2COXDfrNcc5/ZOlTRNAoQqz jE4vCtKUEQFZMjB9TRl054OT8dp7+0v965r31K4GO7PLjgtFhZ6NUDh3V8J1NYiM rTchT5+BfxxWwLuQ7pr4Xa7h4Ph8kca4r/Bp98oe0LRwmuGNtWiEKRhvAh0UTqo= =im7j -----END PGP SIGNATURE----- --r2XQ7XJge8mFC1ic0J0haP3gNkghjqvOj--