From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZccIl-0003nj-0o for qemu-devel@nongnu.org; Thu, 17 Sep 2015 12:44:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZccIg-00018A-Vb for qemu-devel@nongnu.org; Thu, 17 Sep 2015 12:44:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZccIg-000182-Qs for qemu-devel@nongnu.org; Thu, 17 Sep 2015 12:44:46 -0400 References: <1441619584-17992-1-git-send-email-pbonzini@redhat.com> <1441619584-17992-4-git-send-email-pbonzini@redhat.com> <55FAE3A9.5090907@redhat.com> <55FAEB33.50809@redhat.com> From: Eric Blake Message-ID: <55FAEDF8.70604@redhat.com> Date: Thu, 17 Sep 2015 10:44:40 -0600 MIME-Version: 1.0 In-Reply-To: <55FAEB33.50809@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5ntTRcj1DcQWe0C85kUmfo2oKU2PlWnOP" Subject: Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Peter Maydell Cc: Andreas Faerber , Markus Armbruster , Eduardo Habkost , QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5ntTRcj1DcQWe0C85kUmfo2oKU2PlWnOP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/17/2015 10:32 AM, Paolo Bonzini wrote: >>>> Can we revert this one, please? Checkpatch now warns about construct= s >>>> like >>>> typedef struct MyDevice { >>>> DeviceState parent; >>>> >>>> int reg0, reg1, reg2; >>>> } MyDevice; >>> >>> It's interesting that qom/object.h documents this and start like: >>> >>> typedef struct ObjectClass ObjectClass; > I think it varies depending on the maintainer. PPC, USB, SCSI, ACPI al= l > use a separate typedef. I'll prepare a revert. And qapi is about to switch from inline to separate: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04291.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5ntTRcj1DcQWe0C85kUmfo2oKU2PlWnOP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+u34AAoJEKeha0olJ0Nq9D0H/Aj5YY8AyhemzUN2q5OPJ2M+ oW5uy0EKmRiC+YbUpnpQUFfiTmXX1xvveEVUJpvvTKReOZWk5LPZIAL7s7eYHAN1 Dy2Qh9I6tR9p2w3xHHODNU466Ysb4imONFbE+mcsIel32BqSG7OdAzkLnpl5uGpW Wn8cwQVU6GjwFyWkaiHOw//FF7yYF6S98PeU9ZWuToEfb4WwuF1Fpw+YRN7QnIM0 /HKCMtDJ6k1wU0va1cKtxyEGHXQpe3n9p/8NJrFUcmYjZwW6zvNHJx15as2zdpAX 5CfJ1kNobhG1MqdGKAIP8gruBAISHFcPbGpIMLejqdo5hHSpM0qHFn1Gta3PaPM= =hL76 -----END PGP SIGNATURE----- --5ntTRcj1DcQWe0C85kUmfo2oKU2PlWnOP--