From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zce1V-0001SK-Ea for qemu-devel@nongnu.org; Thu, 17 Sep 2015 14:35:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zce1U-0006CH-KI for qemu-devel@nongnu.org; Thu, 17 Sep 2015 14:35:09 -0400 References: <1441140641-17631-1-git-send-email-jsnow@redhat.com> <20150917084009.GE21734@stefanha-thinkpad.redhat.com> From: John Snow Message-ID: <55FB07D6.2040209@redhat.com> Date: Thu, 17 Sep 2015 14:35:02 -0400 MIME-Version: 1.0 In-Reply-To: <20150917084009.GE21734@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] ahci: clean up signature generation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org On 09/17/2015 04:40 AM, Stefan Hajnoczi wrote: > On Tue, Sep 01, 2015 at 04:50:37PM -0400, John Snow wrote: >> Ultimately, clean up the signature generation and as a result, tidy up >> the port_reset and init_d2h functions. >> >> ________________________________________________________________________________ >> >> For convenience, this branch is available at: >> https://github.com/jnsnow/qemu.git branch ahci-sigfix >> https://github.com/jnsnow/qemu/tree/ahci-sigfix >> >> This version is tagged ahci-sigfix-v1: >> https://github.com/jnsnow/qemu/releases/tag/ahci-sigfix-v1 >> >> John Snow (4): >> ahci: remove dead reset code >> ahci: fix signature generation >> ahci: remove cmd_fis argument from write_fis_d2h >> ahci: clean up initial d2h semantics >> >> hw/ide/ahci.c | 53 ++++++++++++++++++++++++++++++----------------------- >> 1 file changed, 30 insertions(+), 23 deletions(-) >> >> -- >> 2.4.3 >> > > Reviewed-by: Stefan Hajnoczi > With the comment in patch 2 fixed: Thanks, applied to my IDE tree: https://github.com/jnsnow/qemu/commits/ide https://github.com/jnsnow/qemu.git --js