From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcfWp-0007TV-6F for qemu-devel@nongnu.org; Thu, 17 Sep 2015 16:11:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcfWm-0000An-1G for qemu-devel@nongnu.org; Thu, 17 Sep 2015 16:11:35 -0400 References: <1441857991-7309-1-git-send-email-eblake@redhat.com> <1441857991-7309-28-git-send-email-eblake@redhat.com> <55FA84C5.8060206@cn.fujitsu.com> <55FACF90.408@redhat.com> From: Eric Blake Message-ID: <55FB1E65.6030402@redhat.com> Date: Thu, 17 Sep 2015 14:11:17 -0600 MIME-Version: 1.0 In-Reply-To: <55FACF90.408@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ktx8bgPLS10P79XSEa84RgE13xks9RMSG" Subject: Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , qemu-devel@nongnu.org Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Vincenzo Maffione , Luiz Capitulino , Max Filippov , Gerd Hoffmann , Dmitry Fleytman , "Edgar E. Iglesias" , Rob Herring , armbru@redhat.com, Scott Feldman , =?UTF-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= , marcandre.lureau@redhat.com, Jiri Pirko , Alistair Francis , Jan Kiszka , Stefan Hajnoczi , Giuseppe Lettieri , Luigi Rizzo , David Gibson , Alexander Graf , Peter Crosthwaite , Michael Walle , "open list:sPAPR pseries" , Peter Chubb This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ktx8bgPLS10P79XSEa84RgE13xks9RMSG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/17/2015 08:34 AM, Eric Blake wrote: >> >> I apply Markus's v8 patch and this series, make check will fail: >> TEST: tests/virtio-net-test... (pid=3D23648) >> /x86_64/virtio/net/pci/basic: = qemu-system-x86_64: -netdev socket,fd=3D6,id=3Dhs0: Invalid parameter 'f= d' >=20 > Oh dear. I guess I was focused on 'make check-qapi-schema', and forgot > to test the rest of the suite. The bug is most likely in my patches, > and will be fixed by the time I post v5, now that you've pointed it out= > to me. Fix is simple: add this patch to your build: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01650.html I've rebased my git repo accordingly for now, and will post v5 later on (I'm still working on other improvements, and may reshuffle patches before actually getting to v5). git fetch git://repo.or.cz/qemu/ericb.git qapi http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ktx8bgPLS10P79XSEa84RgE13xks9RMSG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+x5mAAoJEKeha0olJ0Nq5ZgH/iclXiK204zRAXKyRSByARzj alviKCQaCXkBhBNj80FcYMgKpGpDSWLETPaJujaqSjAExkT13X84c556+kyXlgms 8PcDOYIZ9U+59Pdw4WTzWbBExZyTdC/lpgIUzUFF09dAbotxGiUkPx3kEuZpd9iR 9iURtcX3AcorBhFfHqQNGA2c1hf59h7oiz0ZWRkqfUeFhuBnrzpqIGZoIhdPDvGb cOn7fHO+ZN2ujVTp+pYfr/dLO/5FyQL58zFIfDh6NaQ0Ek0kcChy1Uw6iA2W1G8W LrHfaAUoDQVafCsWmH5iJG6PUoFVV+O2qgvSMmk86XTrhGX4gAPOGyyTDiQer2c= =8Y54 -----END PGP SIGNATURE----- --ktx8bgPLS10P79XSEa84RgE13xks9RMSG--