From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZckGN-0004n0-KZ
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 21:14:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZckGK-000554-Eu
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 21:14:55 -0400
Received: from [59.151.112.132] (port=59026 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZckGK-00050x-19
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 21:14:52 -0400
Message-ID: <55FB6578.2090407@cn.fujitsu.com>
Date: Fri, 18 Sep 2015 09:14:32 +0800
From: Yang Hongyang <yanghy@cn.fujitsu.com>
MIME-Version: 1.0
References: <1442405768-23019-1-git-send-email-yanghy@cn.fujitsu.com>
	<1442405768-23019-3-git-send-email-yanghy@cn.fujitsu.com>
	<55F9DA8A.1090306@redhat.com> <55FA1602.2090309@cn.fujitsu.com>
	<55FAE5CA.20808@redhat.com>
In-Reply-To: <55FAE5CA.20808@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, armbru@redhat.com, stefanha@redhat.com



On 09/18/2015 12:09 AM, Eric Blake wrote:
> On 09/16/2015 07:23 PM, Yang Hongyang wrote:
>
>>>> +{ 'enum': 'NetFilterChain',
>>>> +  'data': [ 'all', 'in', 'out' ] }
>>>
>>> I don't see any other QMP usage of this enum anywhere in the series. Are
>>> you planning on supporting QMP?  If so, let's get that design discussion
>>> started.  If not, why not?
>>
>> This series is based on QOM, so the QMP command for object_add
>> will use this enum, for example:
>>    1 { "execute": "qmp_capabilities" }
>>    2 { "execute": "object-add",
>>    3              "arguments": { "qom-type": "filter-buffer",
>>    4                             "id": "f0",
>>    5                             "props": { "netdev": "bn0",
>>    6                                        "chain": "in",
>>    7                                        "interval": 2000 } } }
>>
>> for hmp:
>> object_add filter-buffer,id=f0,netdev=bn0,chain=in,interval=1000
>>
>> command options:
>> -object filter-buffer,id=f0,netdev=bn0,chain=in,interval=1000
>
> Do these examples appear in the documentation anywhere?  If not, it is
> worth considering (maybe under 'object-add' in qmp-commands.hx, for
> example).

Yes, example is added in the 9th patch, under qemu-options.hx.
Thank you.

>

-- 
Thanks,
Yang.