From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39431)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1ZcrC6-00040v-34
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 04:39:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1ZcrC0-0004lt-QF
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 04:38:57 -0400
References: <1441857991-7309-1-git-send-email-eblake@redhat.com>
	<1441857991-7309-28-git-send-email-eblake@redhat.com>
	<55FA84C5.8060206@cn.fujitsu.com> <55FACF90.408@redhat.com>
	<55FB1E65.6030402@redhat.com> <55FB6041.2060602@cn.fujitsu.com>
	<87d1xg9pvt.fsf@blackfin.pond.sub.org>
From: Wen Congyang <wency@cn.fujitsu.com>
Message-ID: <55FBCCF2.4060505@cn.fujitsu.com>
Date: Fri, 18 Sep 2015 16:36:02 +0800
MIME-Version: 1.0
In-Reply-To: <87d1xg9pvt.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a
 flat union
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Vincenzo Maffione <v.maffione@gmail.com>, Luiz Capitulino <lcapitulino@redhat.com>, Max Filippov <jcmvbkbc@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, Dmitry Fleytman <dmitry@daynix.com>, "Edgar E.
	Iglesias" <edgar.iglesias@gmail.com>, Rob Herring <robh@kernel.org>, Alexander Graf <agraf@suse.de>, Scott Feldman <sfeldma@gmail.com>, dirty.ice.hu@gmail.com, marcandre.lureau@redhat.com, Jiri Pirko <jiri@resnulli.us>, Alistair Francis <alistair.francis@xilinx.com>, Jan Kiszka <jan.kiszka@web.de>, Stefan Hajnoczi <stefanha@redhat.com>, Giuseppe Lettieri <g.lettieri@iet.unipi.it>, Luigi Rizzo <rizzo@iet.unipi.it>, David Gibson <david@gibson.dropbear.id.au>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Michael Walle <michael@walle.cc>, "open
	list:sPAPR pseries" <qemu-ppc@nongnu.org>, Peter Chubb <peter.chubb@nicta.com.au>

On 09/18/2015 02:56 PM, Markus Armbruster wrote:
> Wen Congyang <wency@cn.fujitsu.com> writes:
> 
>> On 09/18/2015 04:11 AM, Eric Blake wrote:
>>> On 09/17/2015 08:34 AM, Eric Blake wrote:
>>>
>>>>>
>>>>> I apply Markus's v8 patch and this series, make check will fail:
>>>>> TEST: tests/virtio-net-test... (pid=23648)
>>>>>   /x86_64/virtio/net/pci/basic: qemu-system-x86_64: -netdev
>>>>> socket,fd=6,id=hs0: Invalid parameter 'fd'
>>>>
>>>> Oh dear. I guess I was focused on 'make check-qapi-schema', and forgot
>>>> to test the rest of the suite.  The bug is most likely in my patches,
>>>> and will be fixed by the time I post v5, now that you've pointed it out
>>>> to me.
>>>
>>> Fix is simple: add this patch to your build:
>>>
>>> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01650.html
>>>
>>> I've rebased my git repo accordingly for now, and will post v5 later on
>>> (I'm still working on other improvements, and may reshuffle patches
>>> before actually getting to v5).
>>>
>>> git fetch git://repo.or.cz/qemu/ericb.git qapi
>>> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi
>>>
>>
>> OK, I will try it. What is difference between start_struct() and
>> start_implicit_struct()?
> 
> I hope to be able to answer this question next week, after taking a dive
> in the (almost entirely undocumented) visitors code.
> .
> 

OK. Supporting NBD driver is hard now. I hope it can be easier in the future.

Thanks
Wen Congyang