From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZctAB-00040M-F6 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 06:45:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZctAA-0006TZ-HI for qemu-devel@nongnu.org; Fri, 18 Sep 2015 06:45:07 -0400 References: <0feb7566cff42d8625ed7263de73fc59225e125f.1442245236.git.berto@igalia.com> From: Max Reitz Message-ID: <55FBEB27.6080702@redhat.com> Date: Fri, 18 Sep 2015 12:44:55 +0200 MIME-Version: 1.0 In-Reply-To: <0feb7566cff42d8625ed7263de73fc59225e125f.1442245236.git.berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QQHXaaoemAsVPbS8p3gr6lf1ufUesOstc" Subject: Re: [Qemu-devel] [PATCH v4 3/4] block: add a 'blockdev-snapshot' QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QQHXaaoemAsVPbS8p3gr6lf1ufUesOstc Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 14.09.2015 18:01, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. >=20 > Extending the command to allow passing options is not a practical > solution because there is overlap between those options and some of > the existing parameters of the command. >=20 > This patch introduces a new 'blockdev-snapshot' command with a simpler > interface: it just takes two references to existing block devices that > will be used as the source and target for the snapshot. >=20 > Since the main difference between the two commands is that one of them > creates and opens the target image, while the other uses an already > opened one, the bulk of the implementation is shared. >=20 > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > Cc: Max Reitz > --- > blockdev.c | 163 ++++++++++++++++++++++++++++++++-----------= -------- > qapi-schema.json | 2 + > qapi/block-core.json | 28 +++++++++ > qmp-commands.hx | 38 ++++++++++++ > 4 files changed, 171 insertions(+), 60 deletions(-) Reviewed-by: Max Reitz --QQHXaaoemAsVPbS8p3gr6lf1ufUesOstc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV++snAAoJEDuxQgLoOKytVhQIAJuNf5D3NAiSdSF+9DnyfpUx 09cQKgYg5+x/9yH8KhIFsFxUVmjrDU8a9Sf8LGow8+WYHkOT4+Miyvk1UliduN5C QUumv7ZIfkeatMy7xtNQ9sQamm7MC7kQwN4roU7w/a8Tz0mDX7Nb71pY/OH4uBzi b0/lakpMo2weUo4s6YTPgTDiU2cpmHbVuCgiO3V9Z+uHcQ80AmkXpaOvhWs0KEX4 uoQ7r32i3nTiX38bidgLmbJpsOwKU25CNkFWreq66HyI5tCmUjMvfGsCWvEMFZ+f pjmZo/Nq3OQgWpMNK1M9F8S/38H+zMeaV4kYsMBz8eS1zu3dwVCFqX5LGo7q3g0= =Enop -----END PGP SIGNATURE----- --QQHXaaoemAsVPbS8p3gr6lf1ufUesOstc--