From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60008)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zcu1w-0004Rj-7W
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 07:40:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zcu1s-0005wn-Cv
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 07:40:39 -0400
Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:33755)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zcu1s-0005wI-3k
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 07:40:36 -0400
Received: by wiclk2 with SMTP id lk2so60739107wic.0
	for <qemu-devel@nongnu.org>; Fri, 18 Sep 2015 04:40:35 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1442570495-22029-1-git-send-email-berrange@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55FBF830.4090701@redhat.com>
Date: Fri, 18 Sep 2015 13:40:32 +0200
MIME-Version: 1.0
In-Reply-To: <1442570495-22029-1-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Makefile: fix build when VPATH is outside
	GIT tree
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Steve Ellcey <sellcey@imgtec.com>, Leon Alrae <leon.alrae@imgtec.com>



On 18/09/2015 12:01, Daniel P. Berrange wrote:
> Steve Ellcey / Leon Alrae reported that QEMU fails to build when
> the VPATH directory is outside of the GIT tree, and the system
> emulators & tools build is disabled. eg
> 
>    cd ..
>    mkdir build
>    cd build
>    ../qemu/configure --disable-system --disable-tools
>    make
>    (...)
>    make[1]: *** No rule to make target `../qom/object.o', needed by `qemu-aarch64'. Stop.
>    make: *** [subdir-aarch64-linux-user] Error 2
> 
> The problem is due to the fact that some sub directory deps
> were listed against SOFTMMU_SUBDIR_RULES instead of SUBDIR_RULES,
> so were only processed for system emulators, not user emalutors.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

Queued, thanks.

Paolo

> ---
>  Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 291fb54..acd261d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -177,7 +177,6 @@ SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
>  
>  $(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
>  $(SOFTMMU_SUBDIR_RULES): $(crypto-obj-y)
> -$(SOFTMMU_SUBDIR_RULES): $(qom-obj-y)
>  $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak
>  
>  subdir-%:
> @@ -202,7 +201,7 @@ subdir-dtc:dtc/libfdt dtc/tests
>  dtc/%:
>  	mkdir -p $@
>  
> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY))
>  
>  ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))
>  romsubdir-%:
>