From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcu2A-0004ev-3u for qemu-devel@nongnu.org; Fri, 18 Sep 2015 07:40:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcu26-0005zJ-Ur for qemu-devel@nongnu.org; Fri, 18 Sep 2015 07:40:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcu26-0005z6-QG for qemu-devel@nongnu.org; Fri, 18 Sep 2015 07:40:50 -0400 References: <1442297513-7001-1-git-send-email-famz@redhat.com> <1442297513-7001-12-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <55FBF83E.6030307@redhat.com> Date: Fri, 18 Sep 2015 13:40:46 +0200 MIME-Version: 1.0 In-Reply-To: <1442297513-7001-12-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JPBlwdO5N4cGndBHOvep6C1k8U4x8wle1" Subject: Re: [Qemu-devel] [PATCH v6 11/14] block/backup: support block job transactions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , vsementsov@parallels.com, stefanha@redhat.com, John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JPBlwdO5N4cGndBHOvep6C1k8U4x8wle1 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 15.09.2015 08:11, Fam Zheng wrote: > From: Stefan Hajnoczi >=20 > Join the transaction when the 'transactional-cancel' QMP argument is > true. >=20 > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is critical so > incremental backup with multiple disks can be retried in case of > cancellation/failure. >=20 > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Fam Zheng > --- > block/backup.c | 25 +++++++-- > blockdev.c | 132 +++++++++++++++++++++++++++++++++++---= -------- > include/block/block_int.h | 3 +- > qapi-schema.json | 4 +- > qapi/block-core.json | 29 ++++++++++ > 5 files changed, 155 insertions(+), 38 deletions(-) With the changes proposed by Eric: Reviewed-by: Max Reitz --JPBlwdO5N4cGndBHOvep6C1k8U4x8wle1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV+/g+AAoJEDuxQgLoOKyttHwH/ijVVw7fvYu0VkXZllLr/mzk 1ozmusbhSY3ADbwQ4OMZ/EbPboooI/APmAjy1HpmaniJo1g1pbOHZCmUS8ngdLOd MqwGTtY51Zia88KUuWIKXzsUu7e0VexCukdnX1rATUXCxxtK0JrXUKaGLQO/dAof Vg6iwmz6PkjGLA/IIOpOuwy+QhvlwjFgJOEpmtIuM3qcnCD1VwwJlFgbFrXwzYqi mgcIdQWXTCTO5+/0bzdLhx1pCJgwfzLTftdwnmmOT9+dfkqilUOCH6U5AopLKwOl VDg8noTjnYCo8gXihkZsYTPraoa/xUSTVUydyIPCpa+eYtmQjnBzmSdQk6WMdFQ= =1xX1 -----END PGP SIGNATURE----- --JPBlwdO5N4cGndBHOvep6C1k8U4x8wle1--