From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcu6f-0001o8-7E for qemu-devel@nongnu.org; Fri, 18 Sep 2015 07:45:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcu6c-0007tD-1d for qemu-devel@nongnu.org; Fri, 18 Sep 2015 07:45:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcu6b-0007t1-Qb for qemu-devel@nongnu.org; Fri, 18 Sep 2015 07:45:29 -0400 References: <1442297513-7001-1-git-send-email-famz@redhat.com> <1442297513-7001-15-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <55FBF955.80100@redhat.com> Date: Fri, 18 Sep 2015 13:45:25 +0200 MIME-Version: 1.0 In-Reply-To: <1442297513-7001-15-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x1WfVmfwtef8twJRCuiC9FpKo7JUg0OKn" Subject: Re: [Qemu-devel] [PATCH v6 14/14] tests: add BlockJobTxn unit test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , vsementsov@parallels.com, stefanha@redhat.com, John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --x1WfVmfwtef8twJRCuiC9FpKo7JUg0OKn Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 15.09.2015 08:11, Fam Zheng wrote: > From: Stefan Hajnoczi >=20 > The BlockJobTxn unit test verifies that both single jobs and pairs of > jobs behave as a transaction group. Either all jobs complete > successfully or the group is cancelled. >=20 > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Fam Zheng > Reviewed-by: Max Reitz > --- > tests/Makefile | 3 + > tests/test-blockjob-txn.c | 244 ++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 247 insertions(+) > create mode 100644 tests/test-blockjob-txn.c >=20 > diff --git a/tests/Makefile b/tests/Makefile > index 34c6136..89ce2f3 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -45,6 +45,8 @@ check-unit-y +=3D tests/test-thread-pool$(EXESUF) > gcov-files-test-thread-pool-y =3D thread-pool.c > gcov-files-test-hbitmap-y =3D util/hbitmap.c > check-unit-y +=3D tests/test-hbitmap$(EXESUF) > +gcov-files-test-hbitmap-y =3D blockjob.c > +check-unit-y +=3D tests/test-blockjob-txn$(EXESUF) > check-unit-y +=3D tests/test-x86-cpuid$(EXESUF) > # all code tested by test-x86-cpuid is inside topology.h > gcov-files-test-x86-cpuid-y =3D > @@ -294,6 +296,7 @@ tests/test-coroutine$(EXESUF): tests/test-coroutine= =2Eo $(block-obj-y) libqemuutil > tests/test-aio$(EXESUF): tests/test-aio.o $(block-obj-y) libqemuutil.a= libqemustub.a > tests/test-rfifolock$(EXESUF): tests/test-rfifolock.o libqemuutil.a li= bqemustub.a > tests/test-throttle$(EXESUF): tests/test-throttle.o $(block-obj-y) lib= qemuutil.a libqemustub.a > +tests/test-blockjob-txn$(EXESUF): tests/test-blockjob-txn.o $(block-ob= j-y) libqemuutil.a libqemustub.a > tests/test-thread-pool$(EXESUF): tests/test-thread-pool.o $(block-obj-= y) libqemuutil.a libqemustub.a > tests/test-iov$(EXESUF): tests/test-iov.o libqemuutil.a > tests/test-hbitmap$(EXESUF): tests/test-hbitmap.o libqemuutil.a libqem= ustub.a This needs an update due to b124533e. The context is obvious, and I guess for the new line itself it's s/\$(block-obj-y).*$/$(test-block-obj-y)/. If that is indeed so, feel free to keep my R-b. Max --x1WfVmfwtef8twJRCuiC9FpKo7JUg0OKn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV+/lVAAoJEDuxQgLoOKytYzsH/AryDTWu7Px5+QDJ10ks5CjA 08pkUp5Vz67cPQubC53eJKF96hNbRBRK5ZHX1SniVi7pD/kMaRDVVIILC5QxZB1W s6rnbDw+IiWBl18pWD5kUJ3xImHmQAM4NCmb4l103RJSMb8FwM2KnpxImUFiWJdc CRl9CQOvGwkfYgdss/2F3DRjv8kTY3GaLnh0zq0OoLRCse/YlzhrseJ/OJtH0Zdc nn3fjZeFKm+cKCHv//fNYpK0hvZwbBzfExlvdRcn7nLNVDGQBGG2di+6CIQr2+bz ThLKqrz5v3pPOhR6xj9yhrv3nFeYxdp03x8Q2W38FQSvhCJU7iJHztlGiimAFLI= =wXSC -----END PGP SIGNATURE----- --x1WfVmfwtef8twJRCuiC9FpKo7JUg0OKn--