From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47346)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Zcw2m-0003oh-Hk
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 09:49:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZcvAD-0001oR-IC
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 08:57:36 -0400
Received: from mx2.suse.de ([195.135.220.15]:48157)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZcvAD-0001nu-9a
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 08:53:17 -0400
References: <1442577640-11612-1-git-send-email-armbru@redhat.com>
	<1442577640-11612-8-git-send-email-armbru@redhat.com>
From: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Message-ID: <55FC093B.7000507@suse.de>
Date: Fri, 18 Sep 2015 14:53:15 +0200
MIME-Version: 1.0
In-Reply-To: <1442577640-11612-8-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 7/7] tests: Simplify how qom-test is run
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, stefanha@redhat.com

Am 18.09.2015 um 14:00 schrieb Markus Armbruster:
> Add it to check-qtest-generic-y instead of check-qtest-$(target)-y for
> every target.
>=20
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  tests/Makefile | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git a/tests/Makefile b/tests/Makefile
> index 4559045..28c5f93 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -219,10 +219,7 @@ gcov-files-ppc64-y +=3D ppc64-softmmu/hw/ppc/spapr=
_pci.c
>  check-qtest-microblazeel-y =3D $(check-qtest-microblaze-y)
>  check-qtest-xtensaeb-y =3D $(check-qtest-xtensa-y)
> =20
> -# qom-test works for all sysemu architectures:
> -$(foreach target,$(SYSEMU_TARGET_LIST), \
> -	$(if $(findstring tests/qom-test$(EXESUF), $(check-qtest-$(target)-y)=
),, \
> -		$(eval check-qtest-$(target)-y +=3D tests/qom-test$(EXESUF))))
> +check-qtest-generic-y +=3D tests/qom-test$(EXESUF)

Does this -generic- have the same filtering code to avoid running the
tests twice for x86_64, aarch64, ppc64, etc.? Please don't regress.

Regards,
Andreas

> =20
>  check-qapi-schema-y :=3D $(addprefix tests/qapi-schema/, \
>  	comments.json empty.json enum-empty.json enum-missing-data.json \
>=20


--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC=
rnberg)