Re: [Qemu-devel] [PATCH v4 2/4] block: support passing 'backing': '' to 'blockdev-add'

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

On 09/15/2015 12:42 AM, Alberto Garcia wrote:
> On Tue 15 Sep 2015 04:27:21 AM CEST, Fam Zheng <famz@redhat.com> wrote:
> 
>>> +    backing = qdict_get_try_str(options, "backing");
>>> +    if (backing && *backing == '\0') {
>>> +        flags |= BDRV_O_NO_BACKING;
>>> +    }
>>> +    qdict_del(options, "backing");
>>> +
> 
>> Specifying a non-empty "backing" will be a slient nop now, but it used
>> to be an error before.  Should we return an error?
> 
> Ah, yes, I think it should return an error. Thanks!

With this squashed in,
Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> --- a/block.c
> +++ b/block.c
> @@ -1473,8 +1473,8 @@ static int bdrv_open_inherit(BlockDriverState
> **pbs, const char *filename,
>      backing = qdict_get_try_str(options, "backing");
>      if (backing && *backing == '\0') {
>          flags |= BDRV_O_NO_BACKING;
> +        qdict_del(options, "backing");
>      }
> -    qdict_del(options, "backing");
> 
> Berto
> 
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]