From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51565)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Zcwr4-0007Ih-3Q
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 10:41:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Zcwqz-0003Ve-AL
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 10:41:38 -0400
References: <cover.1442245236.git.berto@igalia.com>
	<fac86ccf2408b4f417eb744e56edd906b2c0d86b.1442245236.git.berto@igalia.com>
	<20150915022721.GE14016@ad.nay.redhat.com>
	<w51r3m09o9s.fsf@maestria.local.igalia.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55FC2291.1030902@redhat.com>
Date: Fri, 18 Sep 2015 08:41:21 -0600
MIME-Version: 1.0
In-Reply-To: <w51r3m09o9s.fsf@maestria.local.igalia.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="i9SVu6IeOJ8NJvavMgSAUEtXC0mnE3QrC"
Subject: Re: [Qemu-devel] [PATCH v4 2/4] block: support passing 'backing':
 '' to 'blockdev-add'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--i9SVu6IeOJ8NJvavMgSAUEtXC0mnE3QrC
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/15/2015 12:42 AM, Alberto Garcia wrote:
> On Tue 15 Sep 2015 04:27:21 AM CEST, Fam Zheng <famz@redhat.com> wrote:=

>=20
>>> +    backing =3D qdict_get_try_str(options, "backing");
>>> +    if (backing && *backing =3D=3D '\0') {
>>> +        flags |=3D BDRV_O_NO_BACKING;
>>> +    }
>>> +    qdict_del(options, "backing");
>>> +
>=20
>> Specifying a non-empty "backing" will be a slient nop now, but it used=

>> to be an error before.  Should we return an error?
>=20
> Ah, yes, I think it should return an error. Thanks!

With this squashed in,
Reviewed-by: Eric Blake <eblake@redhat.com>

>=20
> --- a/block.c
> +++ b/block.c
> @@ -1473,8 +1473,8 @@ static int bdrv_open_inherit(BlockDriverState
> **pbs, const char *filename,
>      backing =3D qdict_get_try_str(options, "backing");
>      if (backing && *backing =3D=3D '\0') {
>          flags |=3D BDRV_O_NO_BACKING;
> +        qdict_del(options, "backing");
>      }
> -    qdict_del(options, "backing");
>=20
> Berto
>=20
>=20

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--i9SVu6IeOJ8NJvavMgSAUEtXC0mnE3QrC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJV/CKRAAoJEKeha0olJ0Nq7n0H/3fN1+LHyoNPKJ8wtNopknfr
p5ExCtrdCmZTRMisBGoGtDe9/7qSA/XbmWaJCPBM0o7JwmyVANGBrJVEMKrOrZu5
x+T5T8wSM/1T84GWh/nNyPx3Kf64UycNR3jqJbDB0xiqhfnhzqSfQo6vEXLwcPcV
Lh2hBfNAep0uo0mYcee5BK/uoD9WNntLN7psaOibYXXF6Z3cwVh4U/VGyi4bkiHz
lbiFa0iQukCIA/10tFchuabOi+sMAaNqv2s8G7pYL+AFajuVVZgPXmpp4K/j39oK
PxaS93s2Ue94OqyIcSoMV4QrfNyG2X+I8ulQqLd+28yTHGrlLTH6kT3FmWikYXI=
=fSL/
-----END PGP SIGNATURE-----

--i9SVu6IeOJ8NJvavMgSAUEtXC0mnE3QrC--