From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55754)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Zcx1G-0006ZC-UH
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 10:52:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Zcx1F-0008V4-VB
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 10:52:10 -0400
References: <1442571195-27116-1-git-send-email-wency@cn.fujitsu.com>
	<1442571195-27116-2-git-send-email-wency@cn.fujitsu.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55FC2511.6090806@redhat.com>
Date: Fri, 18 Sep 2015 08:52:01 -0600
MIME-Version: 1.0
In-Reply-To: <1442571195-27116-2-git-send-email-wency@cn.fujitsu.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="6Pef5wEaqxqJxAxTa6TaqQIIBvtfmAI3L"
Subject: Re: [Qemu-devel] [PATCH v4 1/4] Add new block driver interface to
 add/delete a BDS's child
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Alberto Garcia <berto@igalia.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu block <qemu-block@nongnu.org>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--6Pef5wEaqxqJxAxTa6TaqQIIBvtfmAI3L
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/18/2015 04:13 AM, Wen Congyang wrote:
> In some cases, we want to take a quorum child offline, and take
> another child online.
>=20
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  block.c                   | 50 +++++++++++++++++++++++++++++++++++++++=
++++++++
>  include/block/block.h     |  5 +++++
>  include/block/block_int.h |  5 +++++
>  3 files changed, 60 insertions(+)
>=20

> +void bdrv_del_child(BlockDriverState *parent_bs, BlockDriverState *chi=
ld_bs,
> +                    Error **errp)
> +{
> +    BdrvChild *child;

> +    if (!child) {
> +        error_setg(errp, "The BDS %s is not the BDS %s's child",
> +                   bdrv_get_device_or_node_name(child_bs),
> +                   bdrv_get_device_or_node_name(parent_bs));

Better would be:

"BDS %s is not a child of %s"

With that,
Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--6Pef5wEaqxqJxAxTa6TaqQIIBvtfmAI3L
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJV/CURAAoJEKeha0olJ0NqDP8IAIr5QjWmOtCu4o55axBEitCl
9S6fecW2qocOB4Uf3RPIpolui6OJgzJdPnxESRjM6N+XJ2t7gI1RaQxrCCPoo1rd
Y/Nnbn5DWZ6z9wqOiRqR9aSx+o1GpGZirOklM/Ad0DgUVb2VEUyp2aiNmgHg75XJ
8Od6iTtmkSO/IFb0lfz6Z3J4kHxiTX1NUn7cHIQQmV/frEztCFaoksaYVTLICodL
Bp7AEPVe/LjBd7XUPZquxWggg1FGbrn/dRr6Uiso8EgxBvnmyTIHsetsS8kAErVo
4Y0NIEaulAfbt4Qq7TcHXVJiCR47MdC8xBORtIBhgouSAPJABuJM8aSXovB0ylw=
=Kb9c
-----END PGP SIGNATURE-----

--6Pef5wEaqxqJxAxTa6TaqQIIBvtfmAI3L--