Re: [Qemu-devel] [PATCH v4 3/4] qmp: add monitor command to add/remove a child

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

On 09/18/2015 04:13 AM, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>

Commit message should probably mention the name of the new commands.

Also, if you still want the command to be experimental, it would be nice
to explain in the commit message why you have chosen that, and what
might change in the future to make us either commit to the interface or
replace it with a better one.

> ---
>  blockdev.c           | 48 ++++++++++++++++++++++++++++++++++++++++++++++
>  qapi/block-core.json | 34 +++++++++++++++++++++++++++++++++
>  qmp-commands.hx      | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 136 insertions(+)


> +SQMP
> +x-blockdev-child-add
> +------------
> +
> +Add a child to a quorum node.
> +
> +Arguments:
> +
> +- "parent": the quorum's id or node name
> +- "child": the child node-name which will be added
> +
> +Note: this command is experimental, and not a stable API. It doesn't
> +support all kinds of child, and not support all block drivers.

s/of child/of children/
s/and not support/nor/

> +
> +Example:
> +
> +-> { "execute": "x-blockdev-child-add",
> +    "arguments": { "parent": "disk1", "child": "new_node" } }
> +<- { "return": {} }

Might be nice to extend the example to show the blockdev-add that
created "new_node" before this command plugs it in.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]