From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcx7A-0002UO-12 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 10:58:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcx76-0004wB-Qj for qemu-devel@nongnu.org; Fri, 18 Sep 2015 10:58:13 -0400 References: <1442571195-27116-1-git-send-email-wency@cn.fujitsu.com> <1442571195-27116-4-git-send-email-wency@cn.fujitsu.com> From: Eric Blake Message-ID: <55FC267D.1000700@redhat.com> Date: Fri, 18 Sep 2015 08:58:05 -0600 MIME-Version: 1.0 In-Reply-To: <1442571195-27116-4-git-send-email-wency@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FTo88mB8EUx7u4LF8lGLVOcucF4Jb2ruu" Subject: Re: [Qemu-devel] [PATCH v4 3/4] qmp: add monitor command to add/remove a child List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , qemu devel , Markus Armbruster , Alberto Garcia , Stefan Hajnoczi Cc: Kevin Wolf , zhanghailiang , qemu block , Jiang Yunhong , Dong Eddie , "Dr. David Alan Gilbert" , Gonglei , Yang Hongyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FTo88mB8EUx7u4LF8lGLVOcucF4Jb2ruu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2015 04:13 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei Commit message should probably mention the name of the new commands. Also, if you still want the command to be experimental, it would be nice to explain in the commit message why you have chosen that, and what might change in the future to make us either commit to the interface or replace it with a better one. > --- > blockdev.c | 48 ++++++++++++++++++++++++++++++++++++++++++++= ++ > qapi/block-core.json | 34 +++++++++++++++++++++++++++++++++ > qmp-commands.hx | 54 ++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 3 files changed, 136 insertions(+) > +SQMP > +x-blockdev-child-add > +------------ > + > +Add a child to a quorum node. > + > +Arguments: > + > +- "parent": the quorum's id or node name > +- "child": the child node-name which will be added > + > +Note: this command is experimental, and not a stable API. It doesn't > +support all kinds of child, and not support all block drivers. s/of child/of children/ s/and not support/nor/ > + > +Example: > + > +-> { "execute": "x-blockdev-child-add", > + "arguments": { "parent": "disk1", "child": "new_node" } } > +<- { "return": {} } Might be nice to extend the example to show the blockdev-add that created "new_node" before this command plugs it in. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FTo88mB8EUx7u4LF8lGLVOcucF4Jb2ruu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV/CZ+AAoJEKeha0olJ0Nq0GcH/jCFODkoLEtYpJdMlfNi3v3Y TP6ySRzmON8WAoU2saFCgL/7yHN0zEaOnxfwFSmRwIaDB4Jgyu06N/MwRe8AmY7a rLicpaQR+tgWjvf7jH0rwUJ6x8DKQ6hIqpcWa0ctluze70EdmuaqkDeRs5TdAqe0 U5rwc162iKE4qoukPsJ+rjrrjAXVLu6I0T0Fo6n+SpTHJsaXEVL31nZwqEyXLSGe YXDCsaI8AOhQzaANn/KB1N/2v1/531vmr+HlMVqbcroWNgK5bGsm4rLLyY+eMiqZ sOqK19eqOQtqH4RWfd6dmuhBIos1TlVABuOqxD+dnLCXqwocM1JAEdqEXA5pTCc= =ov8H -----END PGP SIGNATURE----- --FTo88mB8EUx7u4LF8lGLVOcucF4Jb2ruu--