From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59182)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Zcx96-00067q-0B
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:00:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Zcx90-0007Hp-3K
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:00:15 -0400
References: <1442571195-27116-1-git-send-email-wency@cn.fujitsu.com>
	<1442571195-27116-5-git-send-email-wency@cn.fujitsu.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55FC26F0.5010507@redhat.com>
Date: Fri, 18 Sep 2015 09:00:00 -0600
MIME-Version: 1.0
In-Reply-To: <1442571195-27116-5-git-send-email-wency@cn.fujitsu.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="IujMmJP9EjMom4rPFleh1ofg2iEhG4fMS"
Subject: Re: [Qemu-devel] [PATCH v4 4/4] hmp: add monitor command to
	add/remove a child
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Alberto Garcia <berto@igalia.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu block <qemu-block@nongnu.org>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--IujMmJP9EjMom4rPFleh1ofg2iEhG4fMS
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/18/2015 04:13 AM, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  hmp-commands.hx | 28 ++++++++++++++++++++++++++++
>  hmp.c           | 20 ++++++++++++++++++++
>  hmp.h           |  2 ++
>  3 files changed, 50 insertions(+)
>=20

> +
> +STEXI
> +@item blockdev_child_add @var{parent device} @var{child device}

This produces poor-looking info that makes it appear that the command
takes 4 parameters, with two of those parameters both named 'device'.
I'd use just:

@item blockdev_child_add @var{parent} @var{child}


> +STEXI
> +@item blockdev_child_del @var{parent device} @var{child device}

Likewise.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--IujMmJP9EjMom4rPFleh1ofg2iEhG4fMS
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJV/CbwAAoJEKeha0olJ0Nq2hIIAI+BJYJQeApBgJY8A5zOwDAS
W/njHZqF6CV/k12VZjmZPp85r6noB/J4scYHJ+b9zZy5lpYbexnWgwL6COTIt9YH
ReSv/6XosUVlL6c6V4TxwAJu2EFmmY6u2/vQs0eqtKjy/yPdIInMOkdI793DCJYv
yPTW//zX34jsyRjOgvHkGjxTeqBgB4sh2DamaXdU392Jyy9dUgA4d5mMHlprkA5K
A8LuaX/DTeaU6iow2Qp7bMoSXlLwUPvjC1DJFIPidwxtlCDwJDSop9qd3AtsOORo
EOGVcdmGPbc07+bVCsFlZumVjvL3dzrRE6SNMMWd8OgSCEudQJ3Ie+UVx18mFTU=
=VEBy
-----END PGP SIGNATURE-----

--IujMmJP9EjMom4rPFleh1ofg2iEhG4fMS--