From: Eric Blake <eblake@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/4] utils: rename strtosz to use qemu prefix
Date: Fri, 18 Sep 2015 09:03:04 -0600 [thread overview]
Message-ID: <55FC27A8.6030008@redhat.com> (raw)
In-Reply-To: <1442573994-14632-1-git-send-email-marcandre.lureau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On 09/18/2015 04:59 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
No cover letter? No description of what changed since v1? It's generally
nice to include a 0/4 letter when sending a series; with new enough git,
'git config format.coverLetter auto' does what you want.
> Not only it makes sense, but it gets rid of checkpatch warning:
> WARNING: consider using qemu_strtosz in preference to strtosz
>
> Also remove the tabs to please checkpatch.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Fortunately, this still stands.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-09-18 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 10:59 [Qemu-devel] [PATCH v2 1/4] utils: rename strtosz to use qemu prefix marcandre.lureau
2015-09-18 10:59 ` [Qemu-devel] [PATCH v2 2/4] tests: add some qemu_strtosz() tests marcandre.lureau
2015-09-18 15:05 ` Eric Blake
2015-09-18 15:10 ` Marc-André Lureau
2015-09-18 15:21 ` Eric Blake
2015-09-18 10:59 ` [Qemu-devel] [PATCH v2 3/4] checkpatch: recommend strtok_r marcandre.lureau
2015-09-18 10:59 ` [Qemu-devel] [PATCH v2 4/4] Replace strotok() by strtok_r() marcandre.lureau
2015-09-18 15:22 ` Paolo Bonzini
2015-09-18 15:44 ` Marc-André Lureau
2015-09-18 15:03 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC27A8.6030008@redhat.com \
--to=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).