From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcy7w-0001iD-E8 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 12:03:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcy7t-000899-5J for qemu-devel@nongnu.org; Fri, 18 Sep 2015 12:03:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcxBp-0000hT-RH for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:03:06 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 6B3D49248E for ; Fri, 18 Sep 2015 15:03:05 +0000 (UTC) References: <1442573994-14632-1-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <55FC27A8.6030008@redhat.com> Date: Fri, 18 Sep 2015 09:03:04 -0600 MIME-Version: 1.0 In-Reply-To: <1442573994-14632-1-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jCiENfId3gtWCOFKlGFrBmQQosTfkFlhG" Subject: Re: [Qemu-devel] [PATCH v2 1/4] utils: rename strtosz to use qemu prefix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jCiENfId3gtWCOFKlGFrBmQQosTfkFlhG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2015 04:59 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 No cover letter? No description of what changed since v1? It's generally nice to include a 0/4 letter when sending a series; with new enough git, 'git config format.coverLetter auto' does what you want. > Not only it makes sense, but it gets rid of checkpatch warning: > WARNING: consider using qemu_strtosz in preference to strtosz >=20 > Also remove the tabs to please checkpatch. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > Reviewed-by: Eric Blake Fortunately, this still stands. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jCiENfId3gtWCOFKlGFrBmQQosTfkFlhG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV/CeoAAoJEKeha0olJ0NquY4H/3Knrl8ioKhn73dTGEk0fRxB Vdz8Tn3itkpeRUPdd9YHQ2M5gFvIoNe6M/rufR8iERw7Ewu7zAJnSoNRjVj9NSMA KtJRwRjrH5HSCSFAKNxuEDlPPAXcGyxQ01HDaYiZLGB+kNeoK3JKyCbHjXTdwsGp G9W9AHzeGI5Lt1GwfHpMGZkf143GjzXapVdQkpUTwyrDA32g0RSl2B31B+jy89+b q5W7sSg5heWpJPotAwfhpWcE60aASCND0w8xa7+uVQenIhvRkeRVakrmtjD2WKy7 70HySEp/2ItX8ttMhlRWAuOmOaeOo7Ze8BfqQCT3tW1ilmxwrclAxhpyzawoKQw= =03CF -----END PGP SIGNATURE----- --jCiENfId3gtWCOFKlGFrBmQQosTfkFlhG--