From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcxE1-0002Rf-PM for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:05:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcxDx-0001oS-CP for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:05:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcxDx-0001o3-7o for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:05:17 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D881591761 for ; Fri, 18 Sep 2015 15:05:16 +0000 (UTC) References: <1442573994-14632-1-git-send-email-marcandre.lureau@redhat.com> <1442573994-14632-2-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <55FC282B.2080304@redhat.com> Date: Fri, 18 Sep 2015 09:05:15 -0600 MIME-Version: 1.0 In-Reply-To: <1442573994-14632-2-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m43qV9JOGvkTLuIMPnU8hnS2DwuWfkEiM" Subject: Re: [Qemu-devel] [PATCH v2 2/4] tests: add some qemu_strtosz() tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --m43qV9JOGvkTLuIMPnU8hnS2DwuWfkEiM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2015 04:59 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > While reading the function I decided to write some tests. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > Reviewed-by: Eric Blake > --- > tests/test-cutils.c | 91 +++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 91 insertions(+) I accepted v1 because it was better than no tests at all, but did make some suggestions for additional tests to perform. I'm surprised you didn't include any of those suggestions in v2. For example, it would be nice if the testsuite documents a contract on what happens with a bogus suffix: is "1234x" outright rejected, or does it parse as "1234" leaving the pointer at 'x'? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --m43qV9JOGvkTLuIMPnU8hnS2DwuWfkEiM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEbBAEBCAAGBQJV/CgsAAoJEKeha0olJ0NqA38H91fuxWikl32JLfQN7by8cgeP g7PlulaQB9fBM6rNk77tYg+bwOfOHu0gZDj2WIZNOFZj3xyj4KmmBr5xWqSLe1CL RbPjm4wVSga+BUXv/r3+FfwPO81HQBPByeSG6T8sThiSNEU/qthJNsZSuKWqE23t 0uf57DKTeAREl3koWwZS+RAtCn7BxKozp/332BMaXx3KJloi4UL+HBbFULaUW3g/ 4Y8ul7Rae3OPqy0P+N377lq+IO44qIA2XKqp1sWXbRwkb9kjtUF9ay6QEk2WwKX1 Dbl86soadvwX3ErPYGNSWoD6OH+RHM3HRXsggw02pt47FQUcfU4UvfaxrvuRig== =WNSd -----END PGP SIGNATURE----- --m43qV9JOGvkTLuIMPnU8hnS2DwuWfkEiM--