From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcxL3-0005A0-J4 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:12:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcxL2-0002KD-Hd for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:12:37 -0400 References: From: Eric Blake Message-ID: <55FC29DE.6020601@redhat.com> Date: Fri, 18 Sep 2015 09:12:30 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jp244Un8SoxKMp7j7B3SKM4FKklr8dX0P" Subject: Re: [Qemu-devel] [PATCH v5 0/4] Add 'blockdev-snapshot' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jp244Un8SoxKMp7j7B3SKM4FKklr8dX0P Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2015 07:16 AM, Alberto Garcia wrote: > This fixes the problem detect by Fam: the previous series was deleting > the 'backing' option for 'blockdev-add' even if it contained a > non-empty string. >=20 > The code is also rebased on top of the current master. In particular > the test output had to be adapted because of fe646693. >=20 > Again, this depends on Max's BlockBackend and media series: >=20 > https://lists.gnu.org/archive/html/qemu-block/2015-07/msg00382.html >=20 > Berto >=20 > v5: > - Don't delete the 'backing' option if it contains something different > from an empty string. > - Rebase on top of the current master. Oops, I added some review comments on v4 before seeing that you had already posted v5. I have some potential naming changes to 3/4 that should be considered (namely, s/snapshot/overlay/ for the name of the node that is being added to the chain); and which may necessitate a v6. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jp244Un8SoxKMp7j7B3SKM4FKklr8dX0P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV/CneAAoJEKeha0olJ0NqQz4H/i3A3q8IpgaOTxuWJwgmBTCk IbXGBsUEcxW1+LCIBKzZ8ksy5ELdmmim1lVEdjZpWy2qamdXnhseDNVoki+nKvNk jcXqewZQkTW9EbI5h7KHsgitpGtBRdmlw4A0yjY9oHJxAV5eb7rmMNT+mT4keEll jsWMbHimpGu/BsLxQ+mSjSkvqoQI/tvj/E4cEFMIE3s+kyN4SrImCEWkG4f4ifaA PlyKJtPv5Z/o5N991pKs+pN2r8c0MS+2bBsnWhncqPX5m6xU5gJWb5EQ1Phjk6wM xYLHTRV/F63ycDKSG7DvRpanVLODg+qSVkCSdi7h6zOczRhZHVuYMIgbxFo2J1E= =ym/U -----END PGP SIGNATURE----- --jp244Un8SoxKMp7j7B3SKM4FKklr8dX0P--