From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36761)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZcxSW-0001cm-RQ
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:20:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZcxST-0004gh-Kq
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:20:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51417)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZcxST-0004gY-G8
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:20:17 -0400
References: <1441899541-1856-1-git-send-email-den@openvz.org>
	<1441899541-1856-2-git-send-email-den@openvz.org>
	<87h9mrrcbf.fsf@blackfin.pond.sub.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55FC2BAC.6040402@redhat.com>
Date: Fri, 18 Sep 2015 17:20:12 +0200
MIME-Version: 1.0
In-Reply-To: <87h9mrrcbf.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] hmp-commands-info: move info_cmds
 content out of monitor.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, "Denis V. Lunev" <den@openvz.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Pavel Butsykin <pbutsykin@virtuozzo.com>



On 18/09/2015 17:12, Markus Armbruster wrote:
> "Denis V. Lunev" <den@openvz.org> writes:
> 
>> From: Pavel Butsykin <pbutsykin@virtuozzo.com>
>>
>> For moving target- and device-specific code  from monitor.c,
>> to beginning we move info_cmds content to hmp-commands-info.hx
>>
>> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Peter Maydell <peter.maydell@linaro.org>
> 
> For me, this commit drops "info pci".
> 
> Before:
> 
>     $ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio
>     QEMU 2.4.50 monitor - type 'help' for more information
>     (qemu) info pci
>       Bus  0, device   0, function 0:
>         Host bridge: PCI device 8086:1237
>           id ""
>       Bus  0, device   1, function 0:
>         ISA bridge: PCI device 8086:7000
>           id ""
>       Bus  0, device   1, function 1:
>         IDE controller: PCI device 8086:7010
>           BAR4: I/O at 0xffffffffffffffff [0x000e].
>           id ""
>       Bus  0, device   1, function 3:
>         Bridge: PCI device 8086:7113
>           IRQ 0.
>           id ""
> 
> After:
> 
>     (qemu) info pci
>     unknown command: 'pci'
> 
> Please advise.

s/advise/fix/...  patch sent.  Let me know who shall send it to Peter.

(BTW, it's obvious that I don't scale to 100+ patches per month.  Do you
still have that script of yours looking for unmaintained areas?).

Paolo