From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcxaw-0006gn-TE for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:29:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcxar-0008Hh-G5 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:29:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:58755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcxar-0008HG-A8 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:28:57 -0400 References: <1442577640-11612-1-git-send-email-armbru@redhat.com> <1442577640-11612-8-git-send-email-armbru@redhat.com> <55FC093B.7000507@suse.de> <87io77st3f.fsf@blackfin.pond.sub.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <55FC2DB8.30604@suse.de> Date: Fri, 18 Sep 2015 17:28:56 +0200 MIME-Version: 1.0 In-Reply-To: <87io77st3f.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/7] tests: Simplify how qom-test is run List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, stefanha@redhat.com, ehabkost@redhat.com Am 18.09.2015 um 16:24 schrieb Markus Armbruster: > Andreas F=C3=A4rber writes: >> Am 18.09.2015 um 14:00 schrieb Markus Armbruster: >>> Add it to check-qtest-generic-y instead of check-qtest-$(target)-y fo= r >>> every target. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>> tests/Makefile | 5 +---- >>> 1 file changed, 1 insertion(+), 4 deletions(-) >>> >>> diff --git a/tests/Makefile b/tests/Makefile >>> index 4559045..28c5f93 100644 >>> --- a/tests/Makefile >>> +++ b/tests/Makefile >>> @@ -219,10 +219,7 @@ gcov-files-ppc64-y +=3D ppc64-softmmu/hw/ppc/spa= pr_pci.c >>> check-qtest-microblazeel-y =3D $(check-qtest-microblaze-y) >>> check-qtest-xtensaeb-y =3D $(check-qtest-xtensa-y) >>> =20 >>> -# qom-test works for all sysemu architectures: >>> -$(foreach target,$(SYSEMU_TARGET_LIST), \ >>> - $(if $(findstring tests/qom-test$(EXESUF), >>> $(check-qtest-$(target)-y)),, \ >>> - $(eval check-qtest-$(target)-y +=3D tests/qom-test$(EXESUF)))) >>> +check-qtest-generic-y +=3D tests/qom-test$(EXESUF) >> >> Does this -generic- have the same filtering code to avoid running the >> tests twice for x86_64, aarch64, ppc64, etc.? Please don't regress. >=20 > I'm dense today. Can you explain the filtering code to me? For practical purpose,s x86_64 adds all tests from i386, that included qom-test then. If we now add it for x86_64 too, it got executed twice, which the above $(if ...) fixes by not adding it for x86_64 if it's already in. Just checking whether -generic- has equivalent filtering or other code somewhere else? BR, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N= =C3=BCrnberg)