From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcxgS-0007H0-S7 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:34:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcxgR-0004f8-SI for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:34:44 -0400 References: <1442589793-7105-1-git-send-email-mreitz@redhat.com> <1442589793-7105-4-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <55FC2F0F.4050107@redhat.com> Date: Fri, 18 Sep 2015 09:34:39 -0600 MIME-Version: 1.0 In-Reply-To: <1442589793-7105-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HfKQTSaVFd3I4oUBj6RWgS85taKmfvWqF" Subject: Re: [Qemu-devel] [PATCH v5 03/38] blockdev: Allow creation of BDS trees without BB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Alberto Garcia , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HfKQTSaVFd3I4oUBj6RWgS85taKmfvWqF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2015 09:22 AM, Max Reitz wrote: > If the "id" field is missing from the options given to blockdev-add, > just omit the BlockBackend and create the BlockDriverState tree alone. >=20 > However, if "id" is missing, "node-name" must be specified; otherwise, > the BDS tree would no longer be accessible. >=20 > Many BDS options which are not parsed by bdrv_open() (like caching) > cannot be specified for these BB-less BDS trees yet. A future patch wil= l > remove this limitation. >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 44 +++++++++++++++++++++++++++++++-------= ------ > qapi/block-core.json | 13 +++++++++---- > tests/qemu-iotests/087 | 2 +- > tests/qemu-iotests/087.out | 4 ++-- > 4 files changed, 43 insertions(+), 20 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HfKQTSaVFd3I4oUBj6RWgS85taKmfvWqF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV/C8PAAoJEKeha0olJ0NqUJUH/jdZCZP7yLgZdvbvoDJ5NMvi KbHe2H99+ChY6sQtmNUChoQfzLGK1GzqXKaJ72+nYErFJS9XAQbNG/xVbNyUa8l1 8DQZ8uaIl77+q2KW9qm66Wp0yNRPr5eeBry6v3J8IoGxjL9wgtKtE3SyYT02pjxc UtE3oISkzlxSHxgC6vQAboIT48sqCC1rFrgo0UOnGfBnRbK0XP6OVebb3Z4iL06D FlqfS7VUShZlmESJs0DGt7X1b0ZxBOkNr4I1KwR0m42CNy2eTXPJTu0D1RWp7WFf IBpg0NtsbkSVSy0YKmzGO8/eZAB+3/ZwfwcgjIf5sHhI1dtLr+pesJgRT0frndg= =FNVH -----END PGP SIGNATURE----- --HfKQTSaVFd3I4oUBj6RWgS85taKmfvWqF--