From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcxtD-0004ZJ-Pt for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:47:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcxtC-0005xL-Qv for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:47:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcxtC-0005wr-M6 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:47:54 -0400 References: <1442577640-11612-1-git-send-email-armbru@redhat.com> <1442577640-11612-3-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55FC3224.4010904@redhat.com> Date: Fri, 18 Sep 2015 09:47:48 -0600 MIME-Version: 1.0 In-Reply-To: <1442577640-11612-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="55Wxlk5aLGkplKcDxf5AeMEl5str7KbNb" Subject: Re: [Qemu-devel] [PATCH 2/7] libqtest: New hmp() & friends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: afaerber@suse.de, stefanha@redhat.com, ehabkost@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --55Wxlk5aLGkplKcDxf5AeMEl5str7KbNb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2015 06:00 AM, Markus Armbruster wrote: > New convenience function hmp() to facilitate use of > human-monitor-command in tests. Use it to simplify its existing uses. >=20 > To blend into existing libqtest code, also add qtest_hmpv() and > qtest_hmp(). That, and the egregiously verbose GTK-Doc comment format > make this patch look bigger than it is. >=20 > Signed-off-by: Markus Armbruster > --- > tests/drive_del-test.c | 22 ++++++---------------- > tests/ide-test.c | 8 ++------ > tests/libqtest.c | 35 +++++++++++++++++++++++++++++++++++ > tests/libqtest.h | 33 +++++++++++++++++++++++++++++++++ > 4 files changed, 76 insertions(+), 22 deletions(-) >=20 > @@ -774,6 +801,14 @@ void qmp_discard_response(const char *fmt, ...) > qtest_qmpv_discard_response(global_qtest, fmt, ap); > va_end(ap); > } > +char *hmp(const char *fmt, ...) > +{ > + va_list ap; > + > + va_start(ap, fmt); > + return qtest_hmpv(global_qtest, fmt, ap); > + va_end(ap); Umm, that isn't quite what you meant :) With the dead code after return fixed, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --55Wxlk5aLGkplKcDxf5AeMEl5str7KbNb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV/DIlAAoJEKeha0olJ0Nq+WwIAJz664GtUPCR+Dmryu/enmUx S6YLxdfZwPo1J3ctnpZjbWP9pnAjTnquD4MWkXBFzIrN9thPBs8NKIKuiXnyAKvV MhKvpEWFR7pCvJQdwhF4WVsuOvqldNOlEjPyGJAyePStvd+TECrPInAQdSJ763FS 43Dl/1yYJm+aJJu8TDGxxro4RI6LXX+jrC5KuwlmBhsw+nmdUosOUhN7+K0ynyF7 uxILHGy+0YzLLs+VJ2ZCQO5xlCFI9As2LDpqHMPdUX7ZJrmyfhrCxnvk6xT1sE0E uzli4tqq+S8hJsM015CQatPZHDKv9IhMYjGA8CtoV4i9slVQ03ZqD5+Cpx5fQu8= =vGhS -----END PGP SIGNATURE----- --55Wxlk5aLGkplKcDxf5AeMEl5str7KbNb--