From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcxzq-0004S2-7N for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:54:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcxzp-0002eT-2P for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:54:46 -0400 References: <1442500386-3668-1-git-send-email-berto@igalia.com> From: Max Reitz Message-ID: <55FC33BC.5080803@redhat.com> Date: Fri, 18 Sep 2015 17:54:36 +0200 MIME-Version: 1.0 In-Reply-To: <1442500386-3668-1-git-send-email-berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PxfJP8oj1r4IcN8krLHHuQpXoqCw4RTic" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: test that snapshots move the throttling configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PxfJP8oj1r4IcN8krLHHuQpXoqCw4RTic Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 17.09.2015 16:33, Alberto Garcia wrote: > If a snapshot is performed on a device that has I/O limits they should > be moved to the target image (the new active layer). >=20 > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/096 | 69 ++++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/096.out | 5 ++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 75 insertions(+) > create mode 100644 tests/qemu-iotests/096 > create mode 100644 tests/qemu-iotests/096.out Looks good, I'd just like to throw in that 096 is in use by my looks-dead-but-actually-is-not and only-waiting-for-the-blockbackend-and-media-series-to-get-merged series "block: Rework bdrv_close_all()": http://lists.nongnu.org/archive/html/qemu-block/2015-03/msg00048.html But then again, once the prerequisites are met, I'll have to send a new version of that series anyway... So, since 096 is not a magic number I'm extremely keen on keeping in my greedy claws: Reviewed-by: Max Reitz --PxfJP8oj1r4IcN8krLHHuQpXoqCw4RTic Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV/DO8AAoJEDuxQgLoOKythTcIAIom9AWQ6dg/VBXo/DkDBb4A fEf0EQw2t/6EFVe9Aq2fO0oFvTWHaODblicSNLlD5l508SRBu2KZVwaS6V5SFOHl 2rMgiF99VwoJF6SYplKshJICMOclVUj6biH0QBNIqCNIZEbCvtG2Lc42VXkze7v7 tE96sImR+QZlO7lxmtIGY4QeOQVPpsKx6a4jYoqMCih+Vk6TGki+emAf8jW3Bdbr Pdm6+iYxZHHjIjng02F2O31wjhfjoDNoxdMIFimszltwDtm1Ssx67I5GLKyhthjK LREB1U0D2TBXuuhlYWZy7IrH2WRZJb/D/ktxbR2xdeCieqhUbOrfo3jgyT9gXE0= =WSpr -----END PGP SIGNATURE----- --PxfJP8oj1r4IcN8krLHHuQpXoqCw4RTic--