From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcy0H-0005HP-B0 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:55:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcy0E-00036K-2O for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:55:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcy0D-000368-QY for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:55:10 -0400 References: <1442577640-11612-1-git-send-email-armbru@redhat.com> <1442577640-11612-4-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55FC33DC.8080407@redhat.com> Date: Fri, 18 Sep 2015 09:55:08 -0600 MIME-Version: 1.0 In-Reply-To: <1442577640-11612-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s09rA9a6ttDtDb05X6u9OboNnXJX75RRI" Subject: Re: [Qemu-devel] [PATCH 3/7] device-introspect-test: New, covering device introspection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: afaerber@suse.de, stefanha@redhat.com, ehabkost@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --s09rA9a6ttDtDb05X6u9OboNnXJX75RRI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2015 06:00 AM, Markus Armbruster wrote: > The test doesn't check the output makes any sense, only that QEMU Reads slightly better as: s/check/check that/ > survives. Useful since we've had an astounding number of crash bugs > around there. >=20 > In fact, we have a bunch of them right now: several devices crash or > hang, and all CPUs leave a dangling pointer behind. Blacklist them in > the test. The next commits will fix. >=20 > Signed-off-by: Markus Armbruster > --- > tests/Makefile | 11 ++- > tests/device-introspect-test.c | 149 +++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 157 insertions(+), 3 deletions(-) > create mode 100644 tests/device-introspect-test.c >=20 > @@ -478,8 +483,8 @@ $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): che= ck-qtest-%: $(check-qtest-y) > $(call quiet-command,QTEST_QEMU_BINARY=3D$*-softmmu/qemu-system-$* \ > QTEST_QEMU_IMG=3Dqemu-img$(EXESUF) \ > MALLOC_PERTURB_=3D$${MALLOC_PERTURB_:-$$((RANDOM % 255 + 1))} \ > - gtester $(GTESTER_OPTIONS) -m=3D$(SPEED) $(check-qtest-$*-y),"GTESTE= R $@") > - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y); do \ > + gtester $(GTESTER_OPTIONS) -m=3D$(SPEED) $(check-qtest-generic-y) $(= check-qtest-$*-y),"GTESTER $@") Long line; worth adding a \ line-wrap? > +++ b/tests/device-introspect-test.c > @@ -0,0 +1,149 @@ > +/* > + * Covers QMP device-list-properties and HMP device_add help. We > + * currently don't check their output makes sense, only that QEMU again, might be better as: s/check/check that/ > +static void test_one_device(const char *type) > +{ > + QDict *resp; > + char *help; > + > + /* FIXME device-list-properties crashes for abstract device, skip = */ > + if (strcmp(type, "device")) { > + resp =3D qmp("{'execute': 'device-list-properties'," > + " 'arguments': {'typename': %s}}", > + type); > + QDECREF(resp); > + } > + > + help =3D hmp("device_add \"%s,help\"", type); > + g_free(help); The comment mentions a skip, and the commit message header mentioned a blacklist, but I'm not seeing a skip here. Am I missing something? > + > +static bool blacklisted(const char *type) > +{ > + static const char *blacklist[] =3D { > + /* crash in object_unref(): */ > + "pxa2xx-pcmcia", > + /* hang in object_unref(): */ > + "realview_pci", "versatile_pci", "s390-sclp-event-facility", "= sclp", > + /* create a CPU, thus use after free (see below): */ > + "allwinner-a10", "digic", "fsl,imx25", "fsl,imx31", "xlnx,zynq= mp", > + }; Okay, here's the blacklist the commit message mentioned, but maybe that means the earlier comment is stale? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --s09rA9a6ttDtDb05X6u9OboNnXJX75RRI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV/DPcAAoJEKeha0olJ0NqQ6QIAKEI/JvhQ3TRSPxau6QjiUof gmDgfbq5fcz8uY9hGVdEV0edvR/gf0mK1VK4Uu44iIMooDYM1JC4VAOurdBoi2+l ilZju1g8f5wpNhSes6iJ09NXKDAGy8EcePYWR96oPaBusSH+OFSfapw+zLds6UDt nHvCZNMS3zQSNjlHjfU5gM/wP9PCIXE6wr+Wkc+zB5fs0OQkOeCmuRCZ6rbdRO88 GnIBLI6kBDX4tx52KzWgTc+cUcfef7GB7OvvfTyy4nGyyD8fcv0UMrVXLQC+6S6R 5emSqrXxILpj870NwjEaU22/KrPEkd4Y09uBwln3i3AJZjr6KKvhczsv1hekIHA= =65tn -----END PGP SIGNATURE----- --s09rA9a6ttDtDb05X6u9OboNnXJX75RRI--