From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zcy32-0001iq-Rn for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:58:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zcy31-0005Fq-Uc for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:58:04 -0400 References: <1442577640-11612-1-git-send-email-armbru@redhat.com> <1442577640-11612-5-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55FC3489.1010408@redhat.com> Date: Fri, 18 Sep 2015 09:58:01 -0600 MIME-Version: 1.0 In-Reply-To: <1442577640-11612-5-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RJgh3xc73J8v7H3bJ1MpgtG5aRj1I5WQo" Subject: Re: [Qemu-devel] [PATCH 4/7] qmp: Fix device-list-properties not to crash for abstract device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: ehabkost@redhat.com, qemu-stable@nongnu.org, stefanha@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RJgh3xc73J8v7H3bJ1MpgtG5aRj1I5WQo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2015 06:00 AM, Markus Armbruster wrote: > Broken in commit f4eb32b "qmp: show QOM properties in > device-list-properties", v2.1. >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Markus Armbruster > --- > qmp.c | 6 ++++++ > tests/device-introspect-test.c | 11 ++++------- > 2 files changed, 10 insertions(+), 7 deletions(-) >=20 > +++ b/tests/device-introspect-test.c > @@ -45,13 +45,10 @@ static void test_one_device(const char *type) > QDict *resp; > char *help; > =20 > - /* FIXME device-list-properties crashes for abstract device, skip = */ > - if (strcmp(type, "device")) { Ah, this answers part of my confusion on 3/7. I was looking for so condition on 'abstract', but the skip was based on a condition on 'device' (which happens to be abstract). Don't know if a different wording on that comment would help; maybe: FIXME device-list-properties crashes for device, because it is abstract; skip Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RJgh3xc73J8v7H3bJ1MpgtG5aRj1I5WQo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV/DSKAAoJEKeha0olJ0NqPbIIAKc5aaFOvnC//jugLsBMnPb9 nMKyBCFAR5XQMTVuMgpTowVgf8B23VhTM48CCfZ6UrWL0E8uYU6iRMR5c0vn+w2i kf5/PabcyzbrzRm95W8AD6h1rce8iAVPhxkgLV6vS4gk2/hiEWJWWpUjTyu/pBuk dIx5niB5rQ83ICbr/8hKXJxnFJU1XuPqEC+f+yLPZXhumEN3aICnGNlrP/ATMoUb dF+b6anZoz/SqHUEaHQ+GUkEhwsyK0a+YbYHvLwBGJIsHZFqNwjpHcAyiI8g237c rs00gJBW3dXeyrPB0Uh9GhyJIL0fHJjB14pRLFb7Qt0uKcLQ6U2K7zKD1MNBZEk= =aIN9 -----END PGP SIGNATURE----- --RJgh3xc73J8v7H3bJ1MpgtG5aRj1I5WQo--